206780 - Can't set many non-Western fonts (need port from xpfe)

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Shoshannah Forbes]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030522 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030522 Mozilla Firebird/0.6

Bug #110655 fixed for mozilla but not for firebird- at least not completely: the
first time I open the font prefs, I get mozilla like ui, and I am able to change
the Hebrew fonts.

Any time after, I get fb ui, and I am unable to change any of the Hebrew fonts

I am on osx 10.2.6

Reproducible: Always

Steps to Reproduce:
1. application menu-- prefrences
2. fonts -- for the encoding -- hebre
3. change the font from the default. ok.
4. go back to the fonts and try to change

Actual Results:  
no items in the drop down list for Hebrew fonts

Expected Results:  
shuld list avalible fonts

Comment 1

[Shoshannah Forbes]

Attachment: the drop down list I (don't) get for Hebrew fonts

Comment 2

[Shoshannah Forbes]

Attachment: corrected image

Comment 3

[nivoside]

Attachment: The setting panel on Windows

Although I am using Windows XP of the Japanese version, I cannot set up a
Japanese font.
On this screen [OK] A click of a button will vanish a setup of a font.

2003-05-21-12-trunk & 2003-05-22-16-trunk

Comment 4

[noririty]

Bug 206782 might be related.

-> Hardware:All
-> OS:All

Comment 5

[noririty]

*** Bug 206818 has been marked as a duplicate of this bug. ***

Comment 6

[rbs]

Firebird still uses the old version, and so might need to switch to the newer stuff 
http://lxr.mozilla.org/mozilla/source/browser/components/prefwindow/content/pref-fonts.js

please attach the trunk screenshot for the other side of the story :-)

Comment 7

[rbs]

http://lxr.mozilla.org/mozilla/source/xpfe/components/prefwindow/resources/content/pref-fonts.js

Comment 8

[Tsukasa Maruyama]

Attachment: proposed patch

port fix bug 142511, bug 206782
It seems that this patch is working well on Win.
but I can't check other platform. Would you check someone on *nix and Mac?

Comment 9

[noririty]

Comment on attachment 126513 [details] [diff] [review]
proposed patch

port fix from bug 142511, bug 206782 by [e-mail]

The patch was already tested in bugzilla.jp (Mac OSX,Linux)
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=3232#c2

It works perfectly! A performance issue is same as Mozilla.
And that'll be another bug. Seems low risk to checking this in.

Comment 10

[noririty]

taking

Comment 11

[noririty]

checked in.

Comment 12

[Ryuichi KUBUKI]

In 2003-07-22-12-trunk I got this bug again while 2003-07-21-08-trunk is OK, on
WinXP. Can someone reopen it?

Comment 13

[Ryuichi KUBUKI]

Bug 206843 is WONTFIX, therefore apparently it conflicts with xpfe port of
Mozilla though I prefer behaviour in Mozilla. What I wrote in #12 looks like the
result of endorsement on the Firebird design revealed at Bug 206843.

Comment 14

[Shoshannah Forbes]

Still broken for Hebrew on mac osx, build
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5a) Gecko/20030715
Mozilla Firebird/0.6

Comment 15

[Mike Connor [:mconnor]]

Shoshannah, you have a build four days older than the patch that fixes this
behaviour, of course its still broken.

Marking FIXED again pending a new Mac OS X build (no idea when that is going to be).

Comment 16

[Shoshannah Forbes]

arrghhh. downloaded the latest mac build, and didn't notice the date... Waiting
for an up-todate mac build (what is going on there?)

Comment 17

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 18

[Simon Paquet [:sipaq]]

Verified

Comment 19

[Ryuichi KUBUKI]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030729 Mozilla
Firebird/0.6.1 works again for me.

Comment 20

[Blake Ross]

This patch caused a bad font regression in both firebird and seamonkey and must
be backed out:

In Seamonkey:

- Go to font prefs
- Change the sizes
- Switch panels and switch back

Note that the sizes have reverted.  The same holds true for Firebird.  This is
because your code always initializes the sizes from prefs instead of first
checking if we have a stored size already (i.e. if the user has already set a
size without saving prefs).  This must be fixed or the code backed out.

Comment 21

[Blake Ross]

I checked in a fix. Please test more carefully in the future.

Comment 22

[Mike Connor [:mconnor]]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b)
Gecko/20030817 Mozilla Firebird/0.6.1+

Comment 23

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change