Closed Bug 2068041 Opened 1 month ago Closed 11 days ago

[Nova] There are several inconsistencies between the Create Profile Section and what is presented in Figma

Categories

(Toolkit :: Themes, defect, P3)

Firefox 157
defect

Tracking

()

VERIFIED FIXED
159 Branch
Tracking Status
firefox157 --- wontfix
firefox158 --- wontfix
firefox159 --- verified

People

(Reporter: bcaliman, Assigned: akulyk)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [recomp-nova])

Attachments

(3 files)

Found in

  • Nightly 157

Affected versions
*Nightly 157

Tested platforms

  • Affected platforms: Windows, MacOS, Ubuntu

Preconditions

  • access the Create a New Profile section

Steps to reproduce

  1. Inspect the UI elements of the Create New Profile section

Expected result

Actual result

  • Several inconsistencies are present between the current Nightly Create a New Profile section and the Figma specifications, such as:
  • "Theme" header is missing from Nightly 157
  • The title of the section reads "Customize your new profile" instead of "Create a profile"
  • The buttons are displayed as "Done Editing" and "Delete" instead of "Cancel" and "Create profile"

Additional notes

  • Also attempted to take into consideration the changes specified in 2049709 however the respective mentions are not reflected in Figma
  • The issue occurs on all platforms (MacOS, Windows, Ubuntu)
Has STR: --- → yes
QA Whiteboard: [qa-found-in-c157]
QA Contact: bcaliman
Blocks: 2050120
Summary: There are several inconsistencies between the Create Profile Section and what is presented in Figma → [Nova] There are several inconsistencies between the Create Profile Section and what is presented in Figma
QA Whiteboard: [qa-found-in-c157] → [qa-found-in-c157][S4][QA-5204]
Component: Sidebar → Themes
Product: Firefox → Toolkit
Whiteboard: [fidefe-nova]
Whiteboard: [fidefe-nova] → [recomp-nova]

We intentionally left the copy as is - it's misleading to say the user is creating a new profile, since the profile has already been created and all they can do is edit or delete it at this point. We mentioned this to the content designer and got the following note: "I didn't intentionally make any copy changes to this screen. I think it's fine to revert the copy to what is there today." It's likely Figma just never got updated.

It looks like the label for the theme picker is different across the various screens where we use it (onboarding, HNT, etc) so we probably just need to add a custom label in the profiles case.

Hi folks,
I'm tracking down the issues from the latest QA report that we can reasonably close.
Everything looks as expected to me (based on Hanna's comment), with the exception of the font color and size on the subtitle (Nightly doesn't correspond the Figma). Is this something we'd want to address still? Please see attached.

Flags: needinfo?(hjones)
Flags: needinfo?(git)

Apart from the maybe missing label and with what Hanna wrote, this looks good to me. Not sure if we need that label (as long as there is one for screen readers)

Button order depends on the operating system, so that is correct!

Flags: needinfo?(git)

I believe someone from the Acorn team is going to look at adding the label, then we will close this out

Flags: needinfo?(hjones)
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → akulyk
Pushed by akulyk@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/80bbce8b5c8e https://hg.mozilla.org/integration/autoland/rev/a094137b791f Add a label to the theme picker r=fluent-reviewers,desktop-theme-reviewers,mstriemer,mossop,bolsson
Status: NEW → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

The patch landed in nightly and beta is affected.

:akulyk, please make an uplift decision for beta:

  • For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set status-firefox158 to wontfix if the fix can wait for the next release.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Flags: needinfo?(akulyk)

Hello,

Verified as Fixed on Nightly 159.0a1 (2026-09-27) on Windows 11, MacOS and Ubuntu 26; this along with the information mentioned by :hjones in their comment, I can confirm that:

  • "Theme" header has been added
  • The title of the section reads "Customize your new profile" instead of "Create a profile" - is intended
  • The buttons are displayed as "Done Editing" and "Delete" instead of "Cancel" and "Create profile" - the correct layout is "Done Editing" and "Delete"; also their order is based on the OS running the Firefox app
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-found-in-c157][S4][QA-5204] → [qa-found-in-c157][S4][QA-5204][qa-ver-done-c159]
Status: VERIFIED → RESOLVED
Closed: 14 days ago → 11 days ago
Flags: needinfo?(akulyk)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: