2068594 - Tab count in tab counter is off-center after icon update

Status: RESOLVED FIXED

(Firefox for Android :: Design System and Theming, defect)

Description

[gabriele]

Attachment: IMG_20260901_131021.jpg

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:140.0) Gecko/140.0 Firefox/140.0

Steps to reproduce:

The number indicating the number of open tabs is off-centre

Comment 1

[BugBot [:suhaib / :marco]]

The bug has a release status flag that shows some version of Firefox is affected, thus it will be considered confirmed.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-firefox/firefox] Bug 2068594 - Temporarily fix the alignment of numbers within the tab counter (#356)

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2062819

Comment 4

[Noah Bond [:007]]

Waiting on an updated asset from our icon designer which should fix this issue

Comment 5

[breakingspell]

Some feedback, please ensure this is passed to the decision-maker for icon design.

The new "squished rectangle" with bowed edges is unattractive, even if aligned properly. The former icon square was roughly 1:1.5 ratio while the new icon is 1:2. I am not using a landscape-orientation device like the horizontal icon implies.

Please consider additional vertical height and more rigid edges for the tab count outline, similar to the former icon shape.

Comment 6

[breakingspell]

Attachment: Screenshot_20260917-130755_Firefox.png

Comment 7

[Noah Bond [:007]]

Attachment: image.png

The updated assets were sent over from UX this morning. To fix this visual bug, I'll proceed with these.

https://github.com/FirefoxUX/acorn-icons/blob/main/icons/mobile/24/svg/tab-24.svg
https://github.com/FirefoxUX/acorn-icons/blob/main/icons/mobile/24/svg/infinite-tabs-24.svg

Edit: I found out these are still the old assets. I'm waiting on some correct ones from UX

Comment 8

[Noah Bond [:007]]

Attachment: Bug 2068594 - Update the tab counter icons to the latest design

Comment 9

[Noah Bond [:007]]

Github was not landing the fix and I mistook that for Lando being down, when there's a bug with Github approvals. I've made a new patch on phabricator and it's in the landing queue.

Comment 10

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: This is a highly visible icon in Firefox and is resulting in some loud user feedback.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: The tab counter icon has been updated for the toolbar and tabs tray for both the 0-99 tabs scenario and 100+/infinity scenario.
• Risk associated with taking this patch: low
• Explanation of risk level: This patch updates the icon XML of a vector asset
• String changes made/needed?: n/a
• Is Android affected?: yes

Comment 11

[Noah Bond [:007]]

Attachment: Bug 2068594 - Update the tab counter icons to the latest design

Original Revision: https://phabricator.services.mozilla.com/D328907

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b6513b364538
https://hg.mozilla.org/integration/autoland/rev/b9ab0932ebe8
Update the tab counter icons to the latest design r=android-reviewers,jdelorenzo

Comment 13

[breakingspell]

I've built and tested D328907/D328909. The alignment is fixed, thank you.

I still maintain that the new icon's "squished" shape is an overall downgrade, it visually communicates that the user is viewing on a TV/CRT device, not the case for a mobile device. For posterity, I've opened BUG 2073311 to discuss this design regression caused by the new shape.

Comment 14

[breakingspell]

Attachment: Screenshot_20260924-113923_Firefox Fenix_1.png

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b9ab0932ebe8

Comment 16

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.

:007, please make an uplift decision for beta:

• Nominate the patch for beta uplift approval if the fix should be included in this release, or
• Set status-firefox158 to wontfix if the fix can wait for the next release.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b9ab0932ebe8

Comment 18

[Dianna Smith [:diannaS]]

:007 this needs an uplift request for beta as well

Comment 19

[Noah Bond [:007]]

Added! Thanks, Dianna

Comment 20

[Noah Bond [:007]]

Attachment: Bug 2068594 - Update the tab counter icons to the latest design

Original Revision: https://phabricator.services.mozilla.com/D328907

Comment 21

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: This is a highly visible icon in Firefox and is resulting in some loud user feedback.
• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: The tab counter icon has been updated for the toolbar and tabs tray for both the 0-99 tabs scenario and 100+/infinity scenario.
• Risk associated with taking this patch: low
• Explanation of risk level: This patch updates the icon XML of a vector asset
• String changes made/needed?: n/a
• Is Android affected?: yes

Comment 22

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c37b87849334
https://hg.mozilla.org/releases/mozilla-beta/rev/edcbf53f6a2c