Basic parsing for Declarative Web Push
Categories
(Core :: DOM: Push Subscriptions, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: ltenenbaum, Assigned: ltenenbaum)
References
(Blocks 1 open bug)
Details
Attachments
(2 external files)
Implementing a bare-minimum version of the declarative push message parser to detect and process valid DWPs.
| Assignee | ||
Comment 1•2 months ago
|
||
| Assignee | ||
Comment 2•2 months ago
|
||
Feedback for general design:
For the parsing, we could either introduce a Rust component for push, then use serde_json for parsing (and define the data structure declaratively), or use a JS component as PushCrypto does (although I want to replace it with rust-ece to share more code with the Android code path). I would prefer Rust given rust-ece.
About the notification creation, I think NotificationParent is not a good place to put it as it's intended to be an actor. If we need some shared code path then we should extract it to a separate module.
Thoughts?
| Assignee | ||
Comment 4•2 months ago
|
||
That sounds good! It would definitely be nicer to use serde_json instead of the JSON handler API. And generally I'm in favour of using Rust for more things :)
NotificationParent has some permission checking and creates the alert and NotificationObserver from the IPCNotificationOptions, but I think we can move that to NotificationUtils.cpp or something. I'll file a bug about it.
Comment 7•2 months ago
|
||
Backed out for causing bustages in Declarative.cpp.
Backout link: https://hg.mozilla.org/integration/autoland/rev/f6a50dcf6d0e
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fb45ca7d8ec2ca62f0964d947183206bf542df92
| Assignee | ||
Updated•2 months ago
|
Comment 10•2 months ago
|
||
Backed out for causing failures complaining about Declarative web push.
Backout link: https://hg.mozilla.org/integration/autoland/rev/367b29d1845c
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=592786974&repo=autoland&task=fCMhttTQRNeOWmzuWDPxLA.0&lineNumber=2521
https://treeherder.mozilla.org/logviewer?job_id=592782569&repo=autoland&task=XXSg3ruVRQy1LvQFiKFIAA.0&lineNumber=2531
Updated•2 months ago
|
Ah, we should disable it for android for now, it doesn't support the current WPT infra.
| Assignee | ||
Updated•2 months ago
|
Comment 12•2 months ago
|
||
Comment 13•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d4994aa76b56
https://hg.mozilla.org/mozilla-central/rev/c44bcf352328
Updated•1 month ago
|
Description
•