Closed
Bug 2069065
Opened 2 months ago
Closed 2 months ago
Move some of the notification showing code out of NotificationParent
Categories
(Core :: DOM: Push Subscriptions, task, P3)
Core
DOM: Push Subscriptions
Tracking
()
RESOLVED
FIXED
158 Branch
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: ltenenbaum, Assigned: ltenenbaum)
References
Details
Attachments
(2 external files)
So that we can show Declarative Web Push notifications without a NotificationParent.
| Assignee | ||
Comment 1•2 months ago
|
||
| Assignee | ||
Comment 2•2 months ago
|
||
Pushed by ltenenbaum@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/64f3a67033ae
https://hg.mozilla.org/integration/autoland/rev/c06ba94d7b04
Part 1: Move notification showing out of NotificationParent. r=saschanaz
https://github.com/mozilla-firefox/firefox/commit/118bf6e068b0
https://hg.mozilla.org/integration/autoland/rev/e76b359d483f
Part 2: Move permission and Safe Browsing checks to NotificationUtils.cpp. r=saschanaz
Pushed by rperta@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/0a7d8cbbbf66
https://hg.mozilla.org/integration/autoland/rev/314502c4e3fb
Revert "Bug 2069065 - Part 2: Move permission and Safe Browsing checks to NotificationUtils.cpp. r=saschanaz" for causing build bustages
Pushed by ltenenbaum@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/9273ce93b44d
https://hg.mozilla.org/integration/autoland/rev/08b7f91fb157
Part 1: Move notification showing out of NotificationParent. r=saschanaz
https://github.com/mozilla-firefox/firefox/commit/7878df76762b
https://hg.mozilla.org/integration/autoland/rev/817ca967a024
Part 2: Move permission and Safe Browsing checks to NotificationUtils.cpp. r=saschanaz
Comment 6•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/08b7f91fb157
https://hg.mozilla.org/mozilla-central/rev/817ca967a024
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox158:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c159/b158]
You need to log in
before you can comment on or make changes to this bug.
Description
•