Profiles menu low contrast items (name, icon and back arrow) with some official themes
Categories
(Toolkit :: Themes, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox-esr140 | --- | unaffected |
| firefox-esr153 | --- | unaffected |
| firefox155 | --- | wontfix |
| firefox156 | --- | fix-optional |
| firefox157 | --- | affected |
People
(Reporter: ke5trel, Unassigned, NeedInfo)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-nova])
Attachments
(2 files)
STR:
- Launch latest Nightly 157.0a1 with a selectable profile.
- Install official theme Activist – Balanced (300k users).
- Open the hamburger menu and note the profile icon.
- Click the profiles submenu and note the top area of the menu.
Expected:
Profiles menu content has good contrast.
Actual:
Profile name, icon and back arrow have low contrast, black against dark blue background.
Still happens with browser.nova.enabled = false.
Despite change occurring in Nightly 154, Release 154 was not affected.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=822cf7db64a5d85a1f0b1eecdabb3029b11f1a5f&tochange=9f8c7db0a2090b56e9ce3785b67aff305cd28f45
Regressed by Bug 2046787.
Comment 1•1 day ago
|
||
:nsharpley, since you are the author of the regressor, bug 2046787, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Updated•1 day ago
|
Updated•1 day ago
|
Updated•1 day ago
|
Updated•1 day ago
|
Comment 2•1 day ago
|
||
I noticed this doesn't just occur in the menus, it occurs when selecting a profile from the selector page or editing a profile. It seems there is an issue with the default profile theme itself. I don't think this was caused by my patch. Bogdan, are you able to help with determining a regression window please? Thank you!
Updated•1 day ago
|
Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=1e90f0c3195766562292ebabd90258772145ff04&tochange=0cad2b360015f27eca061e6afe883e3f9a6084be
Possibly regressed by Bug 2050531.
Comment 4•22 hours ago
|
||
Thanks Kestrel!
Hanna, looks like some changes to the theme picker might have caused this. It looks like themeFg is being applied correctly, but is the wrong value for this theme. I had thought perhaps it was these lines that resulted in the wrong foreground color being applied, but I reverted them and the bug still occurs. Any ideas on what I'm missing?
Note that the problem occurs at theme activation time, the existing active theme continues to be unaffected across sessions until it is re-enabled. Most users won't be seeing this unless they are new or toggling their themes.
Description
•