Open Bug 2068917 Opened 1 day ago Updated 8 hours ago

Profiles menu low contrast items (name, icon and back arrow) with some official themes

Categories

(Toolkit :: Themes, defect, P1)

Firefox 155
defect
Points:
1

Tracking

()

Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox-esr153 --- unaffected
firefox155 --- wontfix
firefox156 --- fix-optional
firefox157 --- affected

People

(Reporter: ke5trel, Unassigned, NeedInfo)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-nova])

Attachments

(2 files)

STR:

  1. Launch latest Nightly 157.0a1 with a selectable profile.
  2. Install official theme Activist – Balanced (300k users).
  3. Open the hamburger menu and note the profile icon.
  4. Click the profiles submenu and note the top area of the menu.

Expected:
Profiles menu content has good contrast.

Actual:
Profile name, icon and back arrow have low contrast, black against dark blue background.

Still happens with browser.nova.enabled = false.

Despite change occurring in Nightly 154, Release 154 was not affected.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=822cf7db64a5d85a1f0b1eecdabb3029b11f1a5f&tochange=9f8c7db0a2090b56e9ce3785b67aff305cd28f45

Regressed by Bug 2046787.

:nsharpley, since you are the author of the regressor, bug 2046787, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(nsharpley)
Assignee: nobody → nsharpley
Severity: -- → S3
Points: --- → 1
Flags: needinfo?(nsharpley)
Priority: -- → P1
Whiteboard: [fidefe-nova]

I noticed this doesn't just occur in the menus, it occurs when selecting a profile from the selector page or editing a profile. It seems there is an issue with the default profile theme itself. I don't think this was caused by my patch. Bogdan, are you able to help with determining a regression window please? Thank you!

Flags: needinfo?(bcaliman)
No longer regressed by: 2046787
Blocks: 2049701
Component: Menus → Themes
Flags: needinfo?(bcaliman)
Product: Firefox → Toolkit
Regressed by: 2050531

Thanks Kestrel!

Hanna, looks like some changes to the theme picker might have caused this. It looks like themeFg is being applied correctly, but is the wrong value for this theme. I had thought perhaps it was these lines that resulted in the wrong foreground color being applied, but I reverted them and the bug still occurs. Any ideas on what I'm missing?

Assignee: nsharpley → nobody
Flags: needinfo?(hjones)

Note that the problem occurs at theme activation time, the existing active theme continues to be unaffected across sessions until it is re-enabled. Most users won't be seeing this unless they are new or toggling their themes.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: