Closed Bug 2069022 Opened 2 months ago Closed 1 month ago

[customizable-menu] Show the default browser banner needed by the home menu

Categories

(Firefox for Android :: Menu, task)

All
Android
task

Tracking

()

RESOLVED FIXED
159 Branch
Tracking Status
firefox159 --- fixed

People

(Reporter: petru, Assigned: petru)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][android-core])

Attachments

(5 external files)

Needed:

  • a HomeMenuBuilder that has a hardcoded structure of the default home menu
  • this is instantiated by the MenuStores middleware and queried for the menu configuration to use
  • the configuration is updated by the MenuStores middleware to be displayed
  • the MenuStores middleware will handle the menu item interactions (click + close).
Blocks: 2069025
No longer blocks: 2066831
Assignee: nobody → petru
Status: NEW → ASSIGNED

This is in preparation of supporting showing many of the same menu items
shown in the browser screen's menu in the home screen's menu or in a
custom tab's menu also.
In these other scenarios the menu items should possibly look and behave
differently depending on the tab the menu would target.

We already supported the UI from the compose-menu module.
Now we also add in the MVI configuration for it that will be read from
MenuState to render the banner when appropriately.

BrowserMenuBuilder already had the code needed to build the final structure
for how a menu should look like based on list of menu items configured to show.
Since that same code is needed for home and custom tabs menus also the
BrowserMenuBuilder was refactored to a generic MenuBuilder which gets passed a
menu items list and returns the menu configuration to be displayed.

Pushed by plingurar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/535049143955 https://hg.mozilla.org/integration/autoland/rev/0ab80c8a2b14 Prepare navigating to and building the home menu r=android-reviewers,giorga https://github.com/mozilla-firefox/firefox/commit/798a0fae8fa1 https://hg.mozilla.org/integration/autoland/rev/9796d7395eb7 Let menu items know which tab the menu is for r=android-reviewers,giorga https://github.com/mozilla-firefox/firefox/commit/691bfefee9db https://hg.mozilla.org/integration/autoland/rev/32f170c13d48 Allow showing a banner in the menu r=android-reviewers,giorga https://github.com/mozilla-firefox/firefox/commit/7f74b992e43e https://hg.mozilla.org/integration/autoland/rev/4c93d2e49d2b Ensure menus for browser, home and custom tabs are built the same but with different items r=android-reviewers,giorga https://github.com/mozilla-firefox/firefox/commit/8eadaebdc3bb https://hg.mozilla.org/integration/autoland/rev/bc65103ce107 Show the default browser promotional banner in the home menu r=android-reviewers,giorga
Regressions: 2081925
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: