[customizable-menu] Show the default browser banner needed by the home menu
Categories
(Firefox for Android :: Menu, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox159 | --- | fixed |
People
(Reporter: petru, Assigned: petru)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][android-core])
Attachments
(5 external files)
Needed:
- a
HomeMenuBuilderthat has a hardcoded structure of thedefaulthome menu - this is instantiated by the
MenuStores middleware and queried for the menu configuration to use - the configuration is updated by the
MenuStores middleware to be displayed - the
MenuStores middleware will handle the menu item interactions (click + close).
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
| Assignee | ||
Comment 2•1 month ago
|
||
This is in preparation of supporting showing many of the same menu items
shown in the browser screen's menu in the home screen's menu or in a
custom tab's menu also.
In these other scenarios the menu items should possibly look and behave
differently depending on the tab the menu would target.
| Assignee | ||
Comment 3•1 month ago
|
||
We already supported the UI from the compose-menu module.
Now we also add in the MVI configuration for it that will be read from
MenuState to render the banner when appropriately.
| Assignee | ||
Comment 4•1 month ago
|
||
BrowserMenuBuilder already had the code needed to build the final structure
for how a menu should look like based on list of menu items configured to show.
Since that same code is needed for home and custom tabs menus also the
BrowserMenuBuilder was refactored to a generic MenuBuilder which gets passed a
menu items list and returns the menu configuration to be displayed.
| Assignee | ||
Comment 5•1 month ago
|
||
Comment 7•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0ab80c8a2b14
https://hg.mozilla.org/mozilla-central/rev/9796d7395eb7
https://hg.mozilla.org/mozilla-central/rev/32f170c13d48
https://hg.mozilla.org/mozilla-central/rev/4c93d2e49d2b
https://hg.mozilla.org/mozilla-central/rev/bc65103ce107
Description
•