String deletion clobbered comment for subsequent string
Categories
(Firefox for Android :: Menu, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | unaffected |
| firefox159 | --- | fixed |
| firefox160 | --- | fixed |
People
(Reporter: parker, Assigned: parker)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 external files)
Issue not visible to users.
String deletion in this patch removed the wrong comment.
String A was deleted along with the comment for String B (right below string A).
As a result string B now has an "updated" comment (which is really the original comment for string A).
The original comment for string B must be restored.
| Assignee | ||
Comment 1•1 month ago
|
||
Deletion occured in https://phabricator.services.mozilla.com/D331515
String A was removed but comment for string B was removed with it, and comment for string A left instead. In the github diff, it is rendered as an update to the comment of string B. This patch restores the original comment of string B.
Comment 2•1 month ago
|
||
Set release status flags based on info from the regressing bug 2069022
Comment 4•1 month ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: To revert the regression in the first affected version.
- Code covered by automated testing?: no
- Fix verified in Nightly?: no
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing: --
- Risk associated with taking this patch: low
- Explanation of risk level: String token documentation update.
- String changes made/needed?: Documentation update for
browser_menu_recommended_extensions_content_description - Is Android affected?: yes
Comment 5•1 month ago
|
||
Deletion occured in https://phabricator.services.mozilla.com/D331515
String A was removed but comment for string B was removed with it, and comment for string A left instead. In the github diff, it is rendered as an update to the comment of string B. This patch restores the original comment of string B.
Original Revision: https://phabricator.services.mozilla.com/D333828
Comment 6•1 month ago
|
||
| bugherder | ||
Updated•1 month ago
|
Updated•1 month ago
|
Updated•25 days ago
|
Description
•