2069364 - The Glean instance used for crash pings should read and use the toolkit.telemetry.server pref

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Alex Franchuk [:afranchuk]]

Crash pings use a separate Glean instance for submission, so they do not currently use the toolkit.telemetry.server pref to determine the Glean endpoint. It would be useful to support this pref so that developers could target the staging server.

Comment 1

[Bianca Danforth [:bdanforth]]

Thanks :afranchuk for filing this ticket! For context for others, this arose from this discussion toward Bug 2049499. I'm trying to wire up/test some new infrastructure to connect crash pings in the Glean pipeline to Socorro.

Alex, do you think this is something you (or someone on your team) can do in the very near future, so I can use the testing approach described by Ben in the other ticket? I'm also going to follow up with him to see what other alternatives there may be in the meantime.

Comment 2

[Alex Franchuk [:afranchuk]]

I will have a patch in the next few hours!

Comment 3

[Alex Franchuk [:afranchuk]]

I have a patch ready for desktop, however Android is a little more complicated. I may be able to wrap it up later tonight, otherwise it'll have to wait until Tuesday.

Comment 4

[Alex Franchuk [:afranchuk]]

Attachment: Bug 2069364 p1 - Use toolkit.telemetry.server in the crashreporter client r=gsvelto

Comment 5

[Alex Franchuk [:afranchuk]]

Attachment: Bug 2069364 p2 - Use telemetry server configuration for crash pings on Android r=gsvelto

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6379ebef70e4
https://hg.mozilla.org/integration/autoland/rev/f5c99adc4c97
p1 - Use toolkit.telemetry.server in the crashreporter client r=gsvelto
https://github.com/mozilla-firefox/firefox/commit/e83ac7201c4e
https://hg.mozilla.org/integration/autoland/rev/09841fa9a474
p2 - Use telemetry server configuration for crash pings on Android r=gsvelto,android-reviewers,crashreporting-reviewers,schopin,tcampbell

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f5c99adc4c97
https://hg.mozilla.org/mozilla-central/rev/09841fa9a474

Comment 8

[Bianca Danforth [:bdanforth]]

Thanks for fixing this! I just submitted a test crash ping to Glean, and it was picked up by a test PubSub subscription in socorro stage. I'm working on the cloud function implementation now (see https://mozilla-hub.atlassian.net/browse/CRINGE-440).