2069672 - Fix clang 23 unused warnings in dom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Ryan VanderMeulen [:RyanVM]]

clang 23.1.0 puts -Wunused-template under -Wall and nests -Wunused-but-set-global under -Wunused-but-set-variable, so internal-linkage templates a translation unit never instantiates and file-scope statics that are written but never read both become -Werror failures. Three dom sites, one patch per reviewer group:

• dom/simpledb: QuotaClient::sInstance in dom/simpledb/ActorsParent.cpp is only read by assertions; make it debug-only.
• dom/base: sPopupStatePusherCount in dom/base/PopupBlocker.cpp is only read by assertions; make it debug-only.
• dom/workers: UniquePtrComparator and GetUniquePtrComparator in dom/workers/WorkerPrivate.cpp have no callers; remove them.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2069672 - Make simpledb's QuotaClient::sInstance debug-only. r?#dom-storage-reviewers

Only assertions read it.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2069672 - Make sPopupStatePusherCount debug-only. r?#dom-core-reviewers

Only assertions read it.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2069672 - Remove the unused UniquePtrComparator helpers from WorkerPrivate.cpp. r?#dom-worker-reviewers

They have no callers, and clang 23.1.0 reports unused internal-linkage templates under -Wall.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3389c073d10a
https://hg.mozilla.org/integration/autoland/rev/a95d52084c1c
Make simpledb's QuotaClient::sInstance debug-only. r=dom-storage-reviewers,janv
https://github.com/mozilla-firefox/firefox/commit/199ee8ff91a9
https://hg.mozilla.org/integration/autoland/rev/836dc5593d7b
Make sPopupStatePusherCount debug-only. r=dom-core-reviewers,smaug
https://github.com/mozilla-firefox/firefox/commit/d3725bb6765b
https://hg.mozilla.org/integration/autoland/rev/31a2ecd6b8fb
Remove the unused UniquePtrComparator helpers from WorkerPrivate.cpp. r=dom-worker-reviewers,asuth

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a95d52084c1c
https://hg.mozilla.org/mozilla-central/rev/836dc5593d7b
https://hg.mozilla.org/mozilla-central/rev/31a2ecd6b8fb