2039813 - (clang-23) Update builders to clang 23

Status: REOPENED

(Firefox Build System :: Toolchains, task)

Description

[Mike Hommey [:glandium]]

(when it's released)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 2039813 - Update builders to clang 23.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5a539f1eeedc
https://hg.mozilla.org/integration/autoland/rev/cf77524a41f3
Update builders to clang 23. r=firefox-build-system-reviewers,sylvestre

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd9d5f93df9e
https://hg.mozilla.org/integration/autoland/rev/1591c559e47b
Keep the versioned LLVM dylibs in the macOS clang-tidy package. r=bustage

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/cf77524a41f3
https://hg.mozilla.org/mozilla-central/rev/1591c559e47b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e83796ab25d3
https://hg.mozilla.org/integration/autoland/rev/758cab05b9ba
Revert "Bug 2039813 - Update builders to clang 23. r=firefox-build-system-reviewers,sylvestre" for causing performance regression seen in Bug 2090871.

Comment 6

[Atila Butkovits]

Backed out as requested in https://bugzilla.mozilla.org/show_bug.cgi?id=2090871#c0

Comment 7

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/758cab05b9ba

Comment 8

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e83796ab25d3
https://hg.mozilla.org/integration/autoland/rev/758cab05b9ba
Revert "Bug 2039813 - Update builders to clang 23.
r=firefox-build-system-reviewers,sylvestre" for causing performance
regression seen in Bug 2090871.

Perfherder has detected a browsertime performance change from push 758cab05b9ba9fcb3a8a5cf08080a4678f6c0fd4.

No action is required from the author; this comment is provided for informational purposes only.

Regression	Test	Platform	Options	Absolute values [old vs new]
1%	speedometer3 TodoMVC-JavaScript-ES6-Webpack-Complex-DOM/total (doc)	linux2404-64-shippable	fission webrender	61.60 ms -> 62.39 ms
1%	speedometer3 NewsSite-Nuxt/total (doc)	macosx1500-aarch64-shippable	fission webrender	35.08 ms -> 35.43 ms
1%	speedometer3 NewsSite-Nuxt/total (doc)	linux2404-64-shippable	fission webrender	143.11 ms -> 144.00 ms
1%	speedometer3 (doc)	linux2404-64-shippable	fission webrender	16.33 score -> 16.24 score
1%	speedometer3 score (doc)	linux2404-64-shippable	fission webrender	16.33 score -> 16.24 score
1%	speedometer3 total (doc)	linux2404-64-shippable	fission webrender	1,516.90 ms -> 1,524.64 ms

Improvements	Test	Platform	Options	Absolute values [old vs new]
7%	speedometer3 perfstats-MajorGC (doc)	windows11-64-24h2-shippable	fission webrender	395.91 ms -> 369.92 ms
2%	speedometer3 TodoMVC-WebComponents/total (doc)	windows11-64-24h2-shippable	fission webrender	16.26 ms -> 15.88 ms
2%	speedometer3 Charts-chartjs/total (doc)	windows11-64-24h2-shippable	fission webrender	36.44 ms -> 35.63 ms
2%	speedometer3 TodoMVC-WebComponents/total (doc)	windows11-64-24h2-nightlyasrelease	fission webrender	16.03 ms -> 15.70 ms
2%	speedometer3 Perf-Dashboard/total (doc)	windows11-64-24h2-shippable	fission webrender	56.37 ms -> 55.25 ms
...	...	...	...	...
1%	speedometer3 TodoMVC-Vue/total (doc)	windows11-64-24h2-shippable	fission webrender	24.05 ms -> 23.78 ms

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 9

[Performance Sheriff Bot]

Perfherder has detected a build_metrics performance change from push 758cab05b9ba9fcb3a8a5cf08080a4678f6c0fd4.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
38%	compiler_metrics num_static_constructors	windows2012-64		104.00 -> 64.00

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Comment 10

[Performance Sheriff Bot]

Perfherder has detected a build_metrics performance change from push 758cab05b9ba9fcb3a8a5cf08080a4678f6c0fd4.

No action is required from the author; this comment is provided for informational purposes only.

Regression	Test	Platform	Options	Absolute values [old vs new]
0.27%	installer size	windows2012-64-shippable	nightly	146,669,551.67 -> 147,065,450.58

Improvement	Test	Platform	Options	Absolute values [old vs new]
38%	compiler_metrics num_static_constructors	windows2012-64		104.00 -> 64.00
38%	compiler_metrics num_static_constructors	windows2012-64-shippable	instrumented	110.08 -> 68.00
38%	compiler_metrics num_static_constructors	windows2012-64-shippable		104.00 -> 65.00
35%	compiler_metrics num_static_constructors	windows2012-64		112.00 -> 73.00

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.