2070351 - Can't delete first line of a message filter

Status: ASSIGNED

(Thunderbird :: Filters, defect)

Description

[Ed]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:155.0) Gecko/20100101 Firefox/155.0

Steps to reproduce:

Tried to delete the first line of a message filter.

Actual results:

Nothing. The minus sign is grayed out.

Expected results:

The first line of the filter should have been removed.

Comment 1

[Wayne Mery (:wsmwk)]

Please check Error Console for error or warnings

Comment 2

[Ed]

(In reply to Wayne Mery (:wsmwk) from comment #1)

Please check Error Console for error or warnings

Nothing. Same issue in Troubleshoot mode.

Comment 3

[Magnus Melin [:mkmelin]]

I think you mean the first line of the filter rules.
Yes, that can't be removed, only change to what's desired. The idea is that you should't be able to remove all criteria. I suppose it could be enabled if you have more than the one line.

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2070351 - Correct remaining boolean attribute handling in mail UI. r=#thunderbird-reviewers

Use presence semantics for boolean disabled and checked attributes throughout the mail UI. This makes the first filter row removable once another search condition exists.

Disabled compose color buttons no longer open the color picker, such as before the editor receives focus. Play/Pause and Mute/Unmute context-menu items remain enabled for valid HTML audio and video while staying disabled for media errors.

The attachment-bar checkbox now persists the start-expanded preference correctly. Add regression coverage for the filter-row remove button and attachment-bar preference.

(Followup to bug 2008907)

Comment 5

[Ed]

(In reply to Magnus Melin [:mkmelin] from comment #3)

I think you mean the first line of the filter rules.
Yes, that can't be removed, only change to what's desired. The idea is that you should't be able to remove all criteria. I suppose it could be enabled if you have more than the one line.

Yes, that's what I meant. Some users have had the missing field problem in the first line.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Sorry, missed that Toby still has to review.