2070721 - PiP captions do not appear anymore on dailymotion.com

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, defect)

Description

[Sebastian Zartner [:sebo]]

STR:

1. Load https://www.dailymotion.com/video/xb63g7m
2. Enable captions for the video and ensure they're shown in the original player
3. Enable the PiP player

Expected result:
The captions are also shown in the PiP player.

Action result:
No captions are shown and the captions button is deactivated.

Sebastian

Comment 1

[Sebastian Zartner [:sebo]]

Attachment: Bug 2070721 - Fixed PiP subtitles for Dailymotion videos. r=mconley

It seems that Dailymotion has changed their DOM structure for subtitles in their video player.
So the logic to find the subtitle element has been updated to reflect the new structure.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c693429a18e1
https://hg.mozilla.org/integration/autoland/rev/f040509782d6
Fixed PiP subtitles for Dailymotion videos. r=mconley

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f040509782d6