Closed Bug 2070815 Opened 2 months ago Closed 2 months ago

[Wayland] Disable session restore on Gnome due to Bug 2064100

Categories

(Core :: Widget: Gtk, defect, P1)

defect

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox157 --- fixed
firefox158 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(4 external files)

[Wayland] Disable session restore on Gnome due to Bug 2064100.

Assignee: nobody → stransky
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Crashed on beta/dev edition on Gnome/Fedora 45+ when session restore button is hit.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: disabled wayland session restore
  • String changes made/needed?: none
  • Is Android affected?: no
Attachment #9642387 - Flags: approval-mozilla-beta?
Attachment #9642387 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

The fix here doesn't seem to be enough - I've just hit that crash on Gnome with latest nightly.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by stransky@redhat.com: https://github.com/mozilla-firefox/firefox/commit/98bfd32c15ce https://hg.mozilla.org/integration/autoland/rev/90ef981ca9ec [Wayland] Make MoveToWorkspace()/GetWorkspaceID() no op when session management is disabled r=emilio,gtk-reviewers
Severity: -- → S3
Severity: S3 → N/A
Status: REOPENED → RESOLVED
Closed: 2 months ago → 2 months ago
Resolution: --- → FIXED

Martin, do we want to uplift your follow up fix?

Flags: needinfo?(stransky)

Yes, will submit a beta patch as the recent doesn't apply.

Flags: needinfo?(stransky)

Pascal, we need to uplift Bug 2059617 first for it.

Flags: needinfo?(pascalc)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #13)

Pascal, we need to uplift Bug 2059617 first for it.

Done

Flags: needinfo?(pascalc)

:stransky fyi https://phabricator.services.mozilla.com/D326840 is still missing an uplift request (for release at this point). If you want the second part to ride the 158 train, let us know.

Flags: needinfo?(stransky)

Will request uplift, thanks.

Flags: needinfo?(stransky)
Attachment #9647789 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: crashe on start on gnome 51 / fedora 45+
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: disable on gnome
  • String changes made/needed?: none
  • Is Android affected?: no
Attachment #9647789 - Flags: approval-mozilla-beta? → approval-mozilla-release?

N/A for severity on this bug is wrong, I am changing that to S2

Severity: N/A → S2
Priority: -- → P1
Attachment #9647789 - Flags: approval-mozilla-release? → approval-mozilla-release+
Regressions: 2080242
No longer depends on: 2064100
See Also: → 2064100
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: