nsAppShell.cpp error: use of undeclared identifier 'IsGnomeDesktopEnvironment'
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox-esr153 | --- | unaffected |
| firefox158 | --- | wontfix |
| firefox159 | --- | wontfix |
| firefox160 | --- | fixed |
People
(Reporter: ofthecentury, Assigned: sinker)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 external file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:156.0) Gecko/20100101 Firefox/156.0
Steps to reproduce
Compile FF 157 on FreeBSD in /usr/ports with dbus disabled.
Actual results
, get this error:
/usr/ports/www/firefox/work/firefox-157.0.1/widget/gtk/nsAppShell.cpp:629:9: error: use of undeclared identifier 'IsGnomeDesktopEnvironment'
629 | if (IsGnomeDesktopEnvironment()) {
Expected results
No error.
nsAppShell.cpp has an IF to include the "WidgetUtilsGtk.h" only if MOZ_ENABLE_DBUS is defined, but the compilation with DBUS disabled still requests WidgetUtilsGtk.h for that IsGnomeDesktopEnvironment.
Updated•1 month ago
|
Comment 1•1 month ago
|
||
:stransky, since you are the author of the regressor, bug 2070815, could you take a look?
For more information, please visit BugBot documentation.
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 2•1 month ago
|
||
nsAppShell::IsSessionRestoreSupported() calls IsGnomeDesktopEnvironment()
under MOZ_WAYLAND, but WidgetUtilsGtk.h, which declares it, was included
under MOZ_ENABLE_DBUS only. Builds with dbus disabled fail to compile.
Include the header when either is enabled: the dbus code uses
IsCancelledGError() and the Wayland code uses IsGnomeDesktopEnvironment().
Updated•1 month ago
|
Updated•1 month ago
|
Updated•1 month ago
|
Comment 4•1 month ago
|
||
| bugherder | ||
Comment 5•1 month ago
|
||
The patch landed in nightly and beta is affected.
:sinker, please make an uplift decision for beta:
- For beta, nominate the patch for beta uplift approval if the fix should be included in this release, or set
status-firefox159towontfixif the fix can wait for the next release.
See Requesting an Uplift for documentation on how to request an uplift.
For more information, please visit BugBot documentation.
| Assignee | ||
Updated•1 month ago
|
Updated•22 days ago
|
Description
•