2070960 - Show the result menu button on every row whose context menu has commands

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Dão Gottwald [:dao]]

Bug 2064747 combines a result row's context menu with its result menu, so the three-dot button and a right-click on the row open the same menu.

The button is still added only when the result itself contributes commands (#getResultMenuCommands), while the menu also offers the open-in commands (#getMenuCommands). A row that has nothing but open-in commands - the heuristic search result, top sites - therefore opens a menu on right-click but shows no button.

Add the button whenever the menu would have any commands at all, keying has-menu-button off #getMenuCommands.

We may need to exclude the heuristic result so that the first tab still sends you to the second row which I think is a design choice we haven't decided on giving up.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 2070960 - Show a urlbar result's menu button whenever its menu has commands. r?daisuke!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b389ab0ebf7e
https://hg.mozilla.org/integration/autoland/rev/c0c6c8e864b4
Show a urlbar result's menu button whenever its menu has commands. r=daisuke

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/c0c6c8e864b4