Closed Bug 2071151 Opened 2 months ago Closed 2 months ago

Cherry-pick the upstream extract_symbols.py fixes for clang 23 and fix the cctools-port and winchecksec builds

Categories

(Firefox Build System :: Toolchains, task)

task

Tracking

(firefox158 fixed)

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Follow-ups to Bug 2070447 for the clang 23.1.1 toolchains.

The extract_symbols.py fixes we upstreamed for the clang::interp exports and the Registry<T> accessors have merged, so clang-23.json can carry them as llvmorg-24-init-* cherry-picks and filter-symbols_clang_23.patch shrinks back to the Mozilla-specific size reductions. That also keeps the shared patch applying to clang-trunk, which already has both fixes upstream and no longer accepts the current version.

clang-23.json also needs the upstream fix for a TypePrinter infinite recursion on fully qualified template parameters, which the mozsearch plugin hits on UniquePtr<T[N]>.

Building the other toolchains with clang 23 needs a backport of the libdispatch -Wunused-but-set-global fix and a copy of LLVM 23's llvm-c/Visibility.h and llvm-config.h next to lto.h for cctools-port, and -Wno-unused-template for pe-parse in winchecksec.

llvmorg-24-init-8185-gbe215a25f001.patch and llvmorg-24-init-8187-gbc6c76a4d4f8.patch are the upstream
extract_symbols.py fixes for the clang::interp exports and the Registry<T> accessors, so
filter-symbols_clang_23.patch shrinks back to the Mozilla-specific size reductions. That also keeps it applying
to clang-trunk, which already has both fixes. llvmorg-24-init-7807-g651d01e873c6.patch cherry-picks the upstream
fix for a TypePrinter infinite recursion on FullyQualifiedName template parameters, which the mozsearch plugin
hits on UniquePtr<T[N]>.

libdispatch trips the new -Wunused-but-set-global (backport of the upstream fix the tpoechtrager fork lacks),
cctools-port's configure needs to copy LLVM 23's new llvm-c/Visibility.h and llvm-config.h next to lto.h, and
pe-parse's unused to_string template now warns under /W4 /WX.

Attachment #9640824 - Attachment description: Bug 2071151 - Cherry-pick the upstream clang 23 fixes and fix the cctools-port and winchecksec toolchain builds. r?#firefox-build-system-reviewers → Bug 2071151 - Cherry-pick the upstream clang 23 fixes and fix cctools-port and winchecksec. r?#firefox-build-system-reviewers
Pushed by rvandermeulen@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5b7442979600 https://hg.mozilla.org/integration/autoland/rev/b7d4fceaebf0 Cherry-pick the upstream clang 23 fixes and fix cctools-port and winchecksec. r=firefox-build-system-reviewers,ahochheiden
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: