2071963 - Populate OS, OSVersion, and CPUArchitecture annotations in fenix

Status: RESOLVED FIXED

(Firefox for Android :: Crash Reporting, task)

Description

[Alex Franchuk [:afranchuk]]

https://phabricator.services.mozilla.com/D319599 added the annotations to lib-crash in lib/crash/service/MozillaSocorroService.kt, however Fenix uses lib/crash/service/socorro/MozillaSocorroService.kt.

I don't know why we have two different services, but that's another matter.

Comment 1

[Alex Franchuk [:afranchuk]]

Attachment: Bug 2071963 - Populate OS, OSVersion, CPUArchitecture, and CrashEventID annotations in socorro/MozillaSocorroService r=#crashreporting-reviewers

I noticed that CrashEventID was also missing here.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed41a4e0cf95
https://hg.mozilla.org/integration/autoland/rev/54cd473aca90
Populate OS, OSVersion, CPUArchitecture, and CrashEventID annotations in socorro/MozillaSocorroService r=crashreporting-reviewers,android-reviewers,tcampbell,gsvelto

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/54cd473aca90

Comment 4

[Alex Franchuk [:afranchuk]]

Attachment: Bug 2071963 - Populate OS, OSVersion, CPUArchitecture, and CrashEventID annotations in socorro/MozillaSocorroService

I noticed that CrashEventID was also missing here, so added it.

This moves some annotations into a separate method because detekt was
complaining that the method was too long (and LongMethod can't be
suppressed in the a-c detekt rules(?), though the other impl does
suppress it).

Original Revision: https://phabricator.services.mozilla.com/D325943

Comment 5

[Phabricator Automation]

firefox-esr153 Uplift Approval Request

• User impact if declined/Reason for urgency: Support for ESR crash ping processing in Socorro.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: These patches are simple telemetry additions, and an improvement found in Nightly (reading platform information directly rather than using XPCOM).
• String changes made/needed?: No
• Is Android affected?: yes

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr153/rev/b662a40036c0