Closed Bug 2072134 Opened 1 month ago Closed 21 days ago

[macOS] App authentication window is not reopened if the first authentication is canceled from the Application

Categories

(Core :: Widget: Cocoa, defect)

Firefox 157
Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
158 Branch
Tracking Status
firefox157 --- unaffected
firefox158 --- unaffected
firefox159 --- verified

People

(Reporter: atrif, Assigned: spohl)

References

Details

Attachments

(4 files)

Found in

  • 158.0a1 (2026-09-14)

Affected versions

  • 158.0a1 (2026-09-14)

Tested platforms

  • Affected platforms: macOS 14 aarch
  • Unaffected platforms: Windows 11, Ubuntu 24

Preconditions

  • Evernote installed
  • Firefox is default

Steps to reproduce

  1. Open Evernote and click to log in using google.
  2. Return to the Evernote application and click on cancel.
  3. Click to login with google again.

Expected result

  • The authentication window is reopened.

Actual result

  • The authentication window is not reopened.

Regression range

  • N/A.

Additional notes

  • Screen recording attached: link
Severity: -- → S3
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Pushed by spohl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/adf7e8ed6293 https://hg.mozilla.org/integration/autoland/rev/de3f7b640309 Acknowledge ASWebAuthenticationSession cancellations that the requesting app initiated. r=mac-reviewers,bradwerth https://github.com/mozilla-firefox/firefox/commit/036930ff4417 https://hg.mozilla.org/integration/autoland/rev/d247c3bfd97d Cancel queued ASWebAuthenticationSession requests at shutdown. r=mac-reviewers,bradwerth
Status: ASSIGNED → RESOLVED
Closed: 24 days ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch

Hello! I tried to verify this on macOS 26 aarch, but I can still reproduce the issue with Firefox 158.0a1 (20260922211342). Attached a screen recording: https://drive.google.com/file/d/18oLEP9cSmLy0g7Hm1buuRBtYBj98rvPn/view?usp=sharing. Should we reopen this? Thank you!

Flags: needinfo?(spohl.mozilla.bugs)

Thanks for letting me know! Unfortunately, this is a feature that only works in Nightly, so there was a risk that it might not be completely fixed yet. I believe I have a complete fix now. Reopening this bug to track the followup.

Status: RESOLVED → REOPENED
Flags: needinfo?(spohl.mozilla.bugs)
Resolution: FIXED → ---

AuthenticationServices passes a different ASWebAuthenticationSessionRequest instance to cancelWebAuthenticationSessionRequest: than the one it passed to the begin call, and only a reply on the begin instance reaches the broker.

The broker serializes requests per browser and does not deliver the next one until the current one is answered, so an unanswered cancellation stalls every later request from every app until Firefox restarts.

AuthenticationServices delivers both callbacks on one of its own threads

Pushed by spohl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/234ae107cbe4 https://hg.mozilla.org/integration/autoland/rev/ca686f01e70b Answer OS-initiated ASWebAuthenticationSession cancellations on the request object from the begin call. r=mac-reviewers,bradwerth https://github.com/mozilla-firefox/firefox/commit/143177b67db9 https://hg.mozilla.org/integration/autoland/rev/e18a4b1c6306 Stop assuming the main thread in the ASWebAuthenticationSession handler. r=mac-reviewers,bradwerth

The patch landed in nightly and beta is affected.

:spohl, please make an uplift decision for beta:

  • Nominate the patch for beta uplift approval if the fix should be included in this release, or
  • Set status-firefox158 to wontfix if the fix can wait for the next release.

See Requesting an Uplift for documentation on how to request an uplift.

For more information, please visit BugBot documentation.

Flags: needinfo?(spohl.mozilla.bugs)

This is Nightly only for now.

Flags: needinfo?(spohl.mozilla.bugs)

Verified fixed with Firefox 159.0a1 (2026-09-27) on macOS 26 and 14 aarch using steps from comment 0. Firefox correctly opens the authentication window after following the steps from comment 0.

Status: RESOLVED → VERIFIED
QA Whiteboard: [S3][QA-5475][qa-found-in-c158] → [qa-ver-done-c159/b158] [qa-investig-done-c159/b158] [S3][QA-5475][qa-found-in-c158]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: