Closed Bug 2072535 Opened 2 months ago Closed 1 month ago

Enable Metal ANGLE for WebGL on Nightly

Categories

(Core :: Graphics: CanvasWebGL, task)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: jnicol, Assigned: jnicol)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert, Whiteboard: [fxpe])

Attachments

(3 external files)

I think this is ready for wider testing now.

Performance wise there are some known regressions (e.g. bug 2062897, bug 2057475) and I expect there will be others too, especially on a subtest level. But overall I expect the wins to outweigh the regressions. In any case it will be useful to turn it on and see what comes up.

With ANGLE enabled, the renderer and vendor strings reported by the
ARM macOS 15 workers now include "ANGLE" and "Google Inc."
respectively. Metal ANGLE is blocked on macOS versions older than 12,
therefore the strings reported by the macOS 10.15 workers are
unaffected.

Enabling Metal ANGLE for WebGL causes a bunch of tests to now pass on
aarch64 macOS 15 workers.

However, there are additionally a few tests that must now be skipped
due to assertion failures in debug builds. Note that these are already
skipped on Windows for the same reason.

Whiteboard: [fxpe]
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/764f6a9dfb7f https://hg.mozilla.org/integration/autoland/rev/9db2d0023190 Revert "Bug 2072535 - Update test expectations. r=gfx-reviewers,lsalzman" for causing gfx vendor lint failures
Flags: needinfo?(jnicol)

backed out by mistake

Flags: needinfo?(jnicol)
Pushed by smolnar@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/522415928bec https://hg.mozilla.org/integration/autoland/rev/22c6024900c4 Revert "Bug 2072535 - Update test expectations. r=gfx-reviewers,lsalzman" for causing reftest assertion failures LayersTypes.cpp

Sotaro, I think this might be due to a change you made? The crash seems to occur in the -nogpu test variant so the GPU process is disabled. Does the assertion need to be relaxed to allow this to be used in the parent process?

Flags: needinfo?(jnicol) → needinfo?(sotaro.ikeda.g)

Yes, the assert could be relaxed. Sorry, I forgot to change it in Bug 2068804.

Flags: needinfo?(sotaro.ikeda.g)

Filed and attached fix to bug 2072940

Depends on: 2072940

Perfherder has detected a browsertime performance change from push 6e7f84dbe3c8b8b97f85348d64afddde357e8bae.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new]
3% speedometer3 Perf-Dashboard/total (doc) macosx1500-aarch64-shippable fission no-nova webrender 24.12 ms -> 23.30 ms
3% speedometer3 Perf-Dashboard/total (doc) macosx1500-aarch64-shippable fission webrender 24.15 ms -> 23.40 ms

Need Help or Information?

If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Keywords: perf-alert
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
Regressions: 2073781

Perfherder has detected a browsertime performance change from push c9f9a67f54c76e2c690952d12564b1b7f8d46c3a.

No action is required from the author; this comment is provided for informational purposes only.

Improvement Test Platform Options Absolute values [old vs new] Performance Profiles
5% instagram largestContentfulPaint (doc) macosx1500-aarch64-shippable fission warm webrender 205.13 ms -> 195.41 ms Before/After
4% speedometer3 Perf-Dashboard/total (doc) macosx1500-aarch64-shippable fission webrender 24.05 ms -> 22.97 ms
4% speedometer3 Perf-Dashboard/total (doc) macosx1500-aarch64-shippable fission no-nova webrender 23.99 ms -> 23.14 ms

Need Help or Information?

If you have any questions, please reach out to fbilt@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

Regressions: 2075246
Regressions: 2074540
QA Whiteboard: [qa-triage-done-c159/b158]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: