Closed Bug 2072940 Opened 2 months ago Closed 1 month ago

Relax current process assertion in CompositeProcessFencesHolderId::GetNext

Categories

(Core :: Graphics, task)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: jnicol, Assigned: jnicol)

References

Details

Attachments

(1 external file)

Bug 2068875 changed SharedSurface_IOSurface to use CompositeProcessFencesHolderMap. As a result, when we enable Metal ANGLE (bug 2072535) we now hit this assertion when running tests with the GPU process disabled, as webgl will then run in the parent process. Note this isn't an issue in the wild as the GPU process is enabled by default, and if it gets disabled at runtime then webgl will also be disabled. (Not to mention that Metal ANGLE is still disabled by default.)

In order to enable Metal ANGLE we must relax the assertion to also allow running in the parent process, so that the GPU process disabled tests succeed.

Summary: Relax current process assertion in → Relax current process assertion in CompositeProcessFencesHolderId::GetNext
Blocks: 2072535

To allow execution in the parent process as well. This is required
when running WebGL on Metal ANGLE when the GPU process is disabled by
default (and WebGL therefore runs in the parent process).

Assignee: nobody → jnicol
Status: NEW → ASSIGNED
Pushed by jnicol@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/64e854d7e192 https://hg.mozilla.org/integration/autoland/rev/8906b7e10e6b Relax current process assertion in CompositeProcessFencesHolderId::GetNext() r=gfx-reviewers,nical
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
QA Whiteboard: [qa-triage-done-c159/b158]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: