Closed Bug 2072718 Opened 2 months ago Closed 2 months ago

Migrate keyword types to predefined types

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(67 external files)

The idea here is to allow a more general "not clone" path, and make ~everything use predefined_type.

Add get_<longhand>() accessors returning a reference to the stored computed
value for every longhand whose Gecko storage is the computed value type, and
rename the by-value clone_<longhand>() accessors to slow_clone_<longhand>()
to discourage their use.

Longhands stored in per-layer / per-animation arrays (background-, mask-,
animation-, transition-, scroll-timeline-, view-timeline-), and the few
hand-converted ones (font-size, -x-lang, font-feature-settings,
font-variation-settings) keep only slow_clone_. Keyword longhands whose enum
is still defined by hand in nsStyleConsts.h also keep only slow_clone_ until
they are moved to Rust.

The <longhand>_equals() comparators for the array-backed longhands now
compare the arrays in place instead of cloning both sides, and
differing_properties() uses them.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

The presentation attribute mapping now goes through FromPrimitive like
the other keyword properties, since the value Gecko passes is the enum
itself.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

The presentation attribute mapping now goes through FromPrimitive like
the other keyword properties, since the value Gecko passes is the enum
itself.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in gfxFontConstants.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

The Rust type is called DirectionProperty to avoid clashing with the
existing Direction types in logical_geometry and selector_parser (like
WritingModeProperty), and is renamed back to StyleDirection for C++.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

The discriminants are kept as they were in C++ since they round-trip
through the LookAndFeel underline style integers. The Sentinel alias is
replaced by Wavy, which is what it was.

Both properties share the StyleColorInterpolation enum in Gecko, so
define a single ColorInterpolation enum in Rust and export it through
cbindgen instead of keeping a hand-written copy in nsStyleConsts.h. The
Gecko style struct then stores the computed value type directly and the
style struct getters can hand out references.

Define the enum in Rust and export it through cbindgen, and use it in
nsFont instead of a uint8_t holding NS_FONT_* constants, so the Gecko
style struct stores the computed value type directly and the style
struct getter can hand out a reference.

Define the enum in Rust and export it through cbindgen, and use it in
nsFont instead of a uint8_t holding NS_FONT_* constants, so the Gecko
style struct stores the computed value type directly and the style
struct getter can hand out a reference.

Define the enum in Rust and export it through cbindgen, and use it in
nsFont instead of a uint8_t holding NS_FONT_* constants, so the Gecko
style struct stores the computed value type directly and the style
struct getter can hand out a reference.

Define the enum in Rust and export it through cbindgen, and use it in
nsFont instead of a uint8_t holding NS_FONT_* constants, so the Gecko
style struct stores the computed value type directly and the style
struct getter can hand out a reference.

gfxFontStyle::variantSubSuper becomes the enum too, so the constants go
away entirely.

Define the enum in Rust and export it through cbindgen, and use it in
nsFont instead of a uint8_t holding NS_FONT_* constants, so the Gecko
style struct stores the computed value type directly and the style
struct getter can hand out a reference.

gfxFontStyle::variantCaps becomes the enum too, so the constants go
away entirely.

Define the enum in Rust and export it through cbindgen instead of
keeping a hand-written copy in nsStyleConsts.h, so the Gecko style
struct stores the computed value type directly and the style struct
getter can hand out a reference.

All the single-keyword longhands that Gecko stores now use the computed
value type, so impl_keyword and friends have no remaining users.

Gecko already stores it as StyleBlend, which is now the Rust Blend enum
that mix-blend-mode uses, so share the type instead of converting through
an inexhaustive keyword match. This also makes background-blend-mode
accept plus-lighter, which the compositing spec allows and which
background-blend-mode-plus-lighter.html in WPT tests.

Add a BackgroundOrigin enum shared by both properties (like
BackgroundClip), with background-origin rejecting the SVG boxes at parse
time, and store it in nsStyleImageLayers::Layer instead of the
StyleGeometryBox superset. ComputeBoxValueForOrigin maps it to the
geometry box the painting code uses, so the MarginBox assertion is moot.

It's the last single-keyword longhand. It is internal to Servo, so reuse
the -moz-top-layer enum (none / auto) rather than adding a separate one;
Servo layout can adapt downstream.

Every longhand now has a predefined type, so the Keyword class, the
keyword branch of the longhand template and the image layer keyword
conversions have no users left.

Blocks: 2072783
Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1d8af47e7546 https://hg.mozilla.org/integration/autoland/rev/571b98b1560d Expose borrowed style struct getters and rename clone_ to slow_clone_. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/b0aab8212618 https://hg.mozilla.org/integration/autoland/rev/b110fd0ca8b3 Make box-decoration-break a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/1654bf4a3506 https://hg.mozilla.org/integration/autoland/rev/73094a601044 Make background-attachment a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/8b6f4dd8ccac https://hg.mozilla.org/integration/autoland/rev/bf718ffb35be Make -moz-float-edge a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/cbc2ebc464db https://hg.mozilla.org/integration/autoland/rev/e16e20e5d710 Make -moz-top-layer a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/7e2fd7e61398 https://hg.mozilla.org/integration/autoland/rev/b1941216aae1 Make scroll-behavior a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/47e81211c725 https://hg.mozilla.org/integration/autoland/rev/2afea7559bd6 Make isolation a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/eeb42158e100 https://hg.mozilla.org/integration/autoland/rev/a1b71d720703 Make backface-visibility a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/ecb3a884de36 https://hg.mozilla.org/integration/autoland/rev/59e97da72e59 Make -moz-orient a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/f75301a23c6d https://hg.mozilla.org/integration/autoland/rev/0768b3e42098 Make column-fill a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/2197d3456194 https://hg.mozilla.org/integration/autoland/rev/c54bc2af86fe Make column-span a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/ab12272fe789 https://hg.mozilla.org/integration/autoland/rev/8346d2e787dc Make math-shift a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/da1d6801bffd https://hg.mozilla.org/integration/autoland/rev/3759b3d3a803 Make visibility a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/0fed1bc146c0 https://hg.mozilla.org/integration/autoland/rev/03b3dc892101 Make -moz-box-collapse a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/6069e6406004 https://hg.mozilla.org/integration/autoland/rev/47c1976ed002 Make text-orientation a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/63b111c17df1 https://hg.mozilla.org/integration/autoland/rev/38a19c592f6c Make image-orientation a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/e031423c9f8a https://hg.mozilla.org/integration/autoland/rev/46aca8b0b0ad Make text-anchor a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/4acaeb5bf2d8 https://hg.mozilla.org/integration/autoland/rev/563e28449490 Make shape-rendering a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/02440b882755 https://hg.mozilla.org/integration/autoland/rev/ebf023dfa106 Make stroke-linecap a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/f4e0d3fd4ee9 https://hg.mozilla.org/integration/autoland/rev/9ceeff36fdd5 Make stroke-linejoin a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/fd0d4d483c06 https://hg.mozilla.org/integration/autoland/rev/1dc0dc4e7e7a Make border-collapse a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/82114437cf26 https://hg.mozilla.org/integration/autoland/rev/d197e9dad4c2 Make empty-cells a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/67c6b7c9909f https://hg.mozilla.org/integration/autoland/rev/9e56d964b276 Make hyphens a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/fa1fd8388880 https://hg.mozilla.org/integration/autoland/rev/0013e8702516 Make -moz-text-size-adjust a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/dc71bdeb02b4 https://hg.mozilla.org/integration/autoland/rev/477cfb99b669 Make ruby-align a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/6614024a8f98 https://hg.mozilla.org/integration/autoland/rev/d34fa008427d Make text-combine-upright a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/89c535578be9 https://hg.mozilla.org/integration/autoland/rev/8b58ac8ce5d8 Make text-rendering a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/5b882242e768 https://hg.mozilla.org/integration/autoland/rev/a5b014642671 Make -webkit-text-security a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/75de0d32c9c5 https://hg.mozilla.org/integration/autoland/rev/e32ea060cbcc Make text-wrap-mode a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/449fcf73c334 https://hg.mozilla.org/integration/autoland/rev/1b78254afb37 Make text-wrap-style a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/636234cb0f7e https://hg.mozilla.org/integration/autoland/rev/72f70569c367 Make list-style-position a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/452463157e09 https://hg.mozilla.org/integration/autoland/rev/b26401db57e0 Make flex-direction a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/774524ecd59b https://hg.mozilla.org/integration/autoland/rev/2420e817f613 Make box-sizing a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/0bafc9664f6d https://hg.mozilla.org/integration/autoland/rev/ea9c708f996e Make object-fit a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/2e0b29c4011c https://hg.mozilla.org/integration/autoland/rev/4b80156d623b Make mask-type a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/16b5436da3d2 https://hg.mozilla.org/integration/autoland/rev/cf3eca013353 Make mask-mode a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/0c9ca14c822c https://hg.mozilla.org/integration/autoland/rev/119ecfdc6e80 Make mask-composite a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/fffc66e658f9 https://hg.mozilla.org/integration/autoland/rev/e9a4f893e942 Make table-layout a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/d699e5d862eb https://hg.mozilla.org/integration/autoland/rev/aee176585aed Make unicode-bidi a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/60cc1a5754fb https://hg.mozilla.org/integration/autoland/rev/bd91a238967d Make ime-mode a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/4ee72093c2d3 https://hg.mozilla.org/integration/autoland/rev/8e01390a82b5 Make scrollbar-width a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/1a7b082ab0da https://hg.mozilla.org/integration/autoland/rev/87fd5e2489fd Make -moz-window-dragging a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/2a6dd3b42b38 https://hg.mozilla.org/integration/autoland/rev/37bdc1f33397 Make -moz-window-shadow a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/1ce29de90e0e https://hg.mozilla.org/integration/autoland/rev/b0e0205906d8 Make field-sizing a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/0339bdc01ad7 https://hg.mozilla.org/integration/autoland/rev/3cf64a44a690 Make -moz-box-align a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/dfdb5de68c3a https://hg.mozilla.org/integration/autoland/rev/dfb067945884 Make -moz-box-direction a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/702fcee8c393 https://hg.mozilla.org/integration/autoland/rev/accb8704215e Make -moz-box-orient a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/9c0c87c9561e https://hg.mozilla.org/integration/autoland/rev/027c9e802365 Make -moz-box-pack a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/b38129fbee12 https://hg.mozilla.org/integration/autoland/rev/a2f186c02920 Make mix-blend-mode a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/196d211e5029 https://hg.mozilla.org/integration/autoland/rev/a249548f5043 Make math-style a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/fe4054ca6a7e https://hg.mozilla.org/integration/autoland/rev/79400f5dca1b Make -moz-math-variant a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/32a851978305 https://hg.mozilla.org/integration/autoland/rev/fd9b0b709ee9 Make font-variant-emoji a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/6523b900ab93 https://hg.mozilla.org/integration/autoland/rev/06d860b67ba4 Make direction a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/0e68817bb781 https://hg.mozilla.org/integration/autoland/rev/4746345bc651 Make text-decoration-style a predefined type. r=firefox-style-system-reviewers,layout-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/2c2c06e040e0 https://hg.mozilla.org/integration/autoland/rev/9670a4074804 Make color-interpolation and color-interpolation-filters predefined types. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/26a3c27e28d6 https://hg.mozilla.org/integration/autoland/rev/1ba43ba45746 Make font-optical-sizing a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/6976aef4ba45 https://hg.mozilla.org/integration/autoland/rev/196f372f8f44 Make font-kerning a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/30fc9061a2c0 https://hg.mozilla.org/integration/autoland/rev/07c88ea20675 Make -moz-osx-font-smoothing a predefined type. r=firefox-style-system-reviewers,layout-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/e1de069b00cc https://hg.mozilla.org/integration/autoland/rev/67f8c20113e0 Make font-variant-position a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/afbe05727e03 https://hg.mozilla.org/integration/autoland/rev/880cb43432a1 Make font-variant-caps a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/7ef45017a9b4 https://hg.mozilla.org/integration/autoland/rev/893e0c0d3952 Make white-space-collapse a predefined type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/e585eb2cf675 https://hg.mozilla.org/integration/autoland/rev/43fba7824a6a Remove the keyword conversion templates and use the borrowed getters for the migrated keywords. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/f83dc0ac7f41 https://hg.mozilla.org/integration/autoland/rev/73a371a3a964 Make background-blend-mode use the Blend type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/56da5ffe5167 https://hg.mozilla.org/integration/autoland/rev/a9f6534c1ea0 Make background-origin and mask-origin predefined types. r=firefox-style-system-reviewers,layout-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/c8c1e1fd0081 https://hg.mozilla.org/integration/autoland/rev/b6a6998f0dd3 Make -servo-top-layer use the TopLayer type. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/19b2d639cb87 https://hg.mozilla.org/integration/autoland/rev/a4ca562cfa0c Remove the single-keyword longhand machinery. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/0db6a7c5d492 https://hg.mozilla.org/integration/autoland/rev/65e4357c0d1f Collapse the use statements for the new types into the existing ones. r=firefox-style-system-reviewers,dshin https://github.com/mozilla-firefox/firefox/commit/fb25824ffea9 https://hg.mozilla.org/integration/autoland/rev/4113afefc42d apply code formatting via Lando

https://hg.mozilla.org/mozilla-central/rev/571b98b1560d
https://hg.mozilla.org/mozilla-central/rev/b110fd0ca8b3
https://hg.mozilla.org/mozilla-central/rev/73094a601044
https://hg.mozilla.org/mozilla-central/rev/bf718ffb35be
https://hg.mozilla.org/mozilla-central/rev/e16e20e5d710
https://hg.mozilla.org/mozilla-central/rev/b1941216aae1
https://hg.mozilla.org/mozilla-central/rev/2afea7559bd6
https://hg.mozilla.org/mozilla-central/rev/a1b71d720703
https://hg.mozilla.org/mozilla-central/rev/59e97da72e59
https://hg.mozilla.org/mozilla-central/rev/0768b3e42098
https://hg.mozilla.org/mozilla-central/rev/c54bc2af86fe
https://hg.mozilla.org/mozilla-central/rev/8346d2e787dc
https://hg.mozilla.org/mozilla-central/rev/3759b3d3a803
https://hg.mozilla.org/mozilla-central/rev/03b3dc892101
https://hg.mozilla.org/mozilla-central/rev/47c1976ed002
https://hg.mozilla.org/mozilla-central/rev/38a19c592f6c
https://hg.mozilla.org/mozilla-central/rev/46aca8b0b0ad
https://hg.mozilla.org/mozilla-central/rev/563e28449490
https://hg.mozilla.org/mozilla-central/rev/ebf023dfa106
https://hg.mozilla.org/mozilla-central/rev/9ceeff36fdd5
https://hg.mozilla.org/mozilla-central/rev/1dc0dc4e7e7a
https://hg.mozilla.org/mozilla-central/rev/d197e9dad4c2
https://hg.mozilla.org/mozilla-central/rev/9e56d964b276
https://hg.mozilla.org/mozilla-central/rev/0013e8702516
https://hg.mozilla.org/mozilla-central/rev/477cfb99b669
https://hg.mozilla.org/mozilla-central/rev/d34fa008427d
https://hg.mozilla.org/mozilla-central/rev/8b58ac8ce5d8
https://hg.mozilla.org/mozilla-central/rev/a5b014642671
https://hg.mozilla.org/mozilla-central/rev/e32ea060cbcc
https://hg.mozilla.org/mozilla-central/rev/1b78254afb37
https://hg.mozilla.org/mozilla-central/rev/72f70569c367
https://hg.mozilla.org/mozilla-central/rev/b26401db57e0
https://hg.mozilla.org/mozilla-central/rev/2420e817f613
https://hg.mozilla.org/mozilla-central/rev/ea9c708f996e
https://hg.mozilla.org/mozilla-central/rev/4b80156d623b
https://hg.mozilla.org/mozilla-central/rev/cf3eca013353
https://hg.mozilla.org/mozilla-central/rev/119ecfdc6e80
https://hg.mozilla.org/mozilla-central/rev/e9a4f893e942
https://hg.mozilla.org/mozilla-central/rev/aee176585aed
https://hg.mozilla.org/mozilla-central/rev/bd91a238967d
https://hg.mozilla.org/mozilla-central/rev/8e01390a82b5
https://hg.mozilla.org/mozilla-central/rev/87fd5e2489fd
https://hg.mozilla.org/mozilla-central/rev/37bdc1f33397
https://hg.mozilla.org/mozilla-central/rev/b0e0205906d8
https://hg.mozilla.org/mozilla-central/rev/3cf64a44a690
https://hg.mozilla.org/mozilla-central/rev/dfb067945884
https://hg.mozilla.org/mozilla-central/rev/accb8704215e
https://hg.mozilla.org/mozilla-central/rev/027c9e802365
https://hg.mozilla.org/mozilla-central/rev/a2f186c02920
https://hg.mozilla.org/mozilla-central/rev/a249548f5043
https://hg.mozilla.org/mozilla-central/rev/79400f5dca1b
https://hg.mozilla.org/mozilla-central/rev/fd9b0b709ee9
https://hg.mozilla.org/mozilla-central/rev/06d860b67ba4
https://hg.mozilla.org/mozilla-central/rev/4746345bc651
https://hg.mozilla.org/mozilla-central/rev/9670a4074804
https://hg.mozilla.org/mozilla-central/rev/1ba43ba45746
https://hg.mozilla.org/mozilla-central/rev/196f372f8f44
https://hg.mozilla.org/mozilla-central/rev/07c88ea20675
https://hg.mozilla.org/mozilla-central/rev/67f8c20113e0
https://hg.mozilla.org/mozilla-central/rev/880cb43432a1
https://hg.mozilla.org/mozilla-central/rev/893e0c0d3952
https://hg.mozilla.org/mozilla-central/rev/43fba7824a6a
https://hg.mozilla.org/mozilla-central/rev/73a371a3a964
https://hg.mozilla.org/mozilla-central/rev/a9f6534c1ea0
https://hg.mozilla.org/mozilla-central/rev/b6a6998f0dd3
https://hg.mozilla.org/mozilla-central/rev/a4ca562cfa0c
https://hg.mozilla.org/mozilla-central/rev/65e4357c0d1f
https://hg.mozilla.org/mozilla-central/rev/4113afefc42d
https://hg.mozilla.org/mozilla-central/rev/e494e86e0d5d
https://hg.mozilla.org/mozilla-central/rev/e9b5fe0761a2

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 158 Branch
Blocks: 2074656
QA Whiteboard: [qa-triage-done-c159/b158]
Duplicate of this bug: 2077936
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: