Fix some of the NO_BORROWED_GETTER hacks from bug 2072718
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox158 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(5 external files)
Bug 2072718 introduces NO_BORROWED_GETTER and so to get around some annoying edge cases, but we should fix those instead. Most of them are fine actually (just repr(transparent)), and others like font-size and such are a bit more annoying but nothing crazy.
| Assignee | ||
Comment 1•2 months ago
|
||
Just use the right type on the C++ side.
Updated•2 months ago
|
| Assignee | ||
Comment 2•2 months ago
|
||
We can return a slice rather than relying on the precise underlying type
being generated... Alternatives would involve ugly hacks.
| Assignee | ||
Comment 3•2 months ago
|
||
Use the right type, and simplify a bit some other properties while at it.
| Assignee | ||
Comment 4•2 months ago
|
||
| Assignee | ||
Comment 5•2 months ago
|
||
Use the wr:: version consistently and remove it now that layout uses the
style system one.
| Assignee | ||
Updated•2 months ago
|
Comment 9•2 months ago
|
||
Backed out for causing build bustages
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:44: error: reference to 'FontVariation' is ambiguous
/builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:57: error: reference to 'FontVariation' is ambiguous
/builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:48: error: no member named 'mTag' in 'FontVariation'
/builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:26: error: reference to 'FontVariation' is ambiguous
/builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:17: error: no member named 'mValue' in 'FontVariation'
/builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:47: error: reference to 'FontVariation' is ambiguous
| Assignee | ||
Updated•2 months ago
|
Comment 10•2 months ago
|
||
Comment 11•2 months ago
|
||
Comment 12•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0d293949f7c1
https://hg.mozilla.org/mozilla-central/rev/3ad01375be2c
https://hg.mozilla.org/mozilla-central/rev/fe715e324924
https://hg.mozilla.org/mozilla-central/rev/64cc73ceebff
Updated•1 month ago
|
Description
•