Closed Bug 2072783 Opened 2 months ago Closed 2 months ago

Fix some of the NO_BORROWED_GETTER hacks from bug 2072718

Categories

(Core :: CSS Parsing and Computation, task)

task

Tracking

()

RESOLVED FIXED
158 Branch
Tracking Status
firefox158 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(5 external files)

Bug 2072718 introduces NO_BORROWED_GETTER and so to get around some annoying edge cases, but we should fix those instead. Most of them are fine actually (just repr(transparent)), and others like font-size and such are a bit more annoying but nothing crazy.

Flags: needinfo?(emilio)

Just use the right type on the C++ side.

Assignee: nobody → emilio
Status: NEW → ASSIGNED

We can return a slice rather than relying on the precise underlying type
being generated... Alternatives would involve ugly hacks.

Use the right type, and simplify a bit some other properties while at it.

Use the wr:: version consistently and remove it now that layout uses the
style system one.

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/87bb348650d8 https://hg.mozilla.org/integration/autoland/rev/91b81b420feb Use the same representation for style and graphics variation settings. r=layout-reviewers,jfkthame
Pushed by ctuns@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/93205ced0e6c https://hg.mozilla.org/integration/autoland/rev/58f574768971 Revert "Bug 2072783 - Use the same representation for style and graphics variation settings. r=layout-reviewers,jfkthame" for causing build bustages in gfxMacFont.cpp

Backed out for causing build bustages

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:44: error: reference to 'FontVariation' is ambiguous
    /builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:57: error: reference to 'FontVariation' is ambiguous
    /builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:48: error: no member named 'mTag' in 'FontVariation'
    /builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:26: error: reference to 'FontVariation' is ambiguous
    /builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:17: error: no member named 'mValue' in 'FontVariation'
    /builds/worker/checkouts/gecko/gfx/thebes/gfxMacFont.cpp:X:47: error: reference to 'FontVariation' is ambiguous
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
QA Whiteboard: [qa-triage-done-c159/b158]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: