[IPProtection][a11y] Improve TalkBack accessibility semantics for the built-in VPN menu item
Categories
(Firefox for Android :: Privacy, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox159 | --- | verified |
People
(Reporter: corentin, Assigned: corentin)
References
(Blocks 2 open bugs)
Details
(Keywords: access, Whiteboard: [fxdroid] [group2] [android-activation-trust])
Attachments
(1 file, 1 external file)
|
1017.12 KB,
video/mp4
|
Details |
Prerequisites
- TalkBack accessibility service is enabled.
- Fx Nightly installed.
Steps to reproduce
- Open the main menu
- Click the VPN row in the main menu
- Listen to Talkback speech
Expected behavior
TalkBack announces something coherent, description the row as a whole, such as VPN, switch, on.
Actual behavior
TalkBack announces ON, VPN, ON.
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
IPProtectionMenuItem exposed its status twice for screen readers:
- The row sets a
stateDescriptionbased on the current status - The
Badgedisplays the same status description
debouncedClickable is based on clickable, which merges semantics of its children, so the text of the badge was merged into the row semantics and announced twice by screen readers ("ON, VPN, ON, switch").
To prevent this duplication, semantics of the badge are now cleared so that the state description of the row is the only source. Now the screen reader says "ON, VPN, switch"
Some tests have been added to cover accessibility for all states. Also, tests have been renamed to use GIVEN ... WHEN ... THEN ... pattern.
Updated•1 month ago
|
Comment 3•1 month ago
|
||
| bugherder | ||
Comment 4•1 month ago
|
||
Ticket verified in Fx Nightly 159.0a1 (Build #2016188666) on a Google Pixel 7a (Android 16). When focusing on the VPN section from the HNT, Existing tab, or Trust Panel menu, TalkBack announces: "On, VPN, switch, double tap to activate" / "Off, VPN, switch, double tap to activate".
Corentin, after double-tapping the VPN section to change the VPN state, TalkBack announces: "On, VPN, Open VPN settings button, switch". Is having "Open VPN settings button" in that order expected, or should it come after "switch"? Thanks!
| Assignee | ||
Comment 5•1 month ago
|
||
Thank you! The extra Open VPN settings button is not intended. TalkBack should announce only the new state, such as On or Off, like a standard switch. I have created a follow-up bug (Bug 2080131) to fix this issue.
Comment 6•1 month ago
|
||
In this case I will mark this one as verified and will keep track of bug 2080131. Thank you!
Description
•