Closed Bug 2072926 Opened 2 months ago Closed 1 month ago

[IPProtection][a11y] Improve TalkBack accessibility semantics for the built-in VPN menu item

Categories

(Firefox for Android :: Privacy, defect, P3)

Firefox 157
All
Android
defect
Points:
2

Tracking

()

VERIFIED FIXED
159 Branch
Tracking Status
firefox159 --- verified

People

(Reporter: corentin, Assigned: corentin)

References

(Blocks 2 open bugs)

Details

(Keywords: access, Whiteboard: [fxdroid] [group2] [android-activation-trust])

Attachments

(1 file, 1 external file)

Prerequisites

  • TalkBack accessibility service is enabled.
  • Fx Nightly installed.

Steps to reproduce

  1. Open the main menu
  2. Click the VPN row in the main menu
  3. Listen to Talkback speech

Expected behavior

TalkBack announces something coherent, description the row as a whole, such as VPN, switch, on.

Actual behavior

TalkBack announces ON, VPN, ON.

Severity: -- → S4
Points: --- → 2
Priority: -- → P3

IPProtectionMenuItem exposed its status twice for screen readers:

  • The row sets a stateDescription based on the current status
  • The Badge displays the same status description

debouncedClickable is based on clickable, which merges semantics of its children, so the text of the badge was merged into the row semantics and announced twice by screen readers ("ON, VPN, ON, switch").

To prevent this duplication, semantics of the badge are now cleared so that the state description of the row is the only source. Now the screen reader says "ON, VPN, switch"

Some tests have been added to cover accessibility for all states. Also, tests have been renamed to use GIVEN ... WHEN ... THEN ... pattern.

Attachment #9645815 - Attachment description: WIP: Bug 2072926 - Hide the VPN menu item badge for screen readers → Bug 2072926 - Hide the VPN menu item badge for screen readers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 159 Branch
Attached video output135.mp4 —

Ticket verified in Fx Nightly 159.0a1 (Build #2016188666) on a Google Pixel 7a (Android 16). When focusing on the VPN section from the HNT, Existing tab, or Trust Panel menu, TalkBack announces: "On, VPN, switch, double tap to activate" / "Off, VPN, switch, double tap to activate".

Corentin, after double-tapping the VPN section to change the VPN state, TalkBack announces: "On, VPN, Open VPN settings button, switch". Is having "Open VPN settings button" in that order expected, or should it come after "switch"? Thanks!

Flags: needinfo?(cbect)
See Also: → 2080131

Thank you! The extra Open VPN settings button is not intended. TalkBack should announce only the new state, such as On or Off, like a standard switch. I have created a follow-up bug (Bug 2080131) to fix this issue.

Flags: needinfo?(cbect)

In this case I will mark this one as verified and will keep track of bug 2080131. Thank you!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: