Closed Bug 2080131 Opened 1 month ago Closed 1 month ago

[IPProtection][a11y] TalkBack wrongly announces the VPN settings button when toggling the built-in VPN menu item

Categories

(Firefox for Android :: Privacy, defect, P3)

Firefox 159
All
Android
defect
Points:
1

Tracking

()

VERIFIED FIXED
160 Branch
Tracking Status
firefox160 --- verified

People

(Reporter: corentin, Assigned: corentin)

References

(Blocks 2 open bugs)

Details

(Keywords: access, Whiteboard: [android-activation-trust])

Attachments

(1 external file)

Prerequisites

  • TalkBack accessibility service is enabled.
  • Fx Nightly installed.

Steps to reproduce

  1. Open the main menu
  2. Focus the VPN row in the main menu
  3. Double tap to toggle the VPN
  4. Listen to Talkback speech

Expected behavior

TalkBack announces only the new state, such as On or Off, like a standard switch.

Actual behavior

TalkBack announces On, VPN, Open VPN settings button, switch.

Notes

Reported in bug 2072926, comment 4.

Flags: qe-verify+

IPProtectionMenuItem set liveRegion on the row, so on every state change, TalkBack reads the whole content of the row, including the nested settings button (On, VPN, Open VPN settings button, switch).

The row already exposes its status through stateDescription, which Talkback announces when the row is focused and the status is updated. The live region has been removed so that toggling the row now only announces the new state (On, Off), like a standard switch.

Attachment #9656784 - Attachment description: WIP: Bug 2080131 - Remove the live region from the built-in VPN menu item → Bug 2080131 - Remove the live region from the built-in VPN menu item
Pushed by cbect@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f136161bf69e https://hg.mozilla.org/integration/autoland/rev/8260d160650e Remove the live region from the built-in VPN menu item r=android-reviewers,gmalekpour
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
See Also: → 2081598

Ticket verified in Fx Nightly 160.0a1 (Build #2016190207) with a Google Android 7A (Android 16). After double tapping on the VPN section from menus, TalkBack announces "On" or "Off".

Corentin I did notice something. It seems after selecting the VPN section, for the first double tap TalkBack is not announcing the VPN state, only for the following double taps. Signing out and back again seems to reproduce this again. Please let me know if you observe something else from the screen recording. Should a following bug be logged for this? Thank you!

Flags: needinfo?(cbect)

Thanks for verifying the fix.

It seems that the VPN item sometimes loose the accessibility focus, I suspect it may be related to the second issue you reported. I have been able to reproduce the issue on my Pixel 5. Good catch! Could you please create a bug with your observations for this separate issue? Thank you!

Flags: needinfo?(cbect)

Hi, here's the follow-up bug: 2082783. Thank you!

I will mark this one as verified and keep an eye on the follow-up. Thank you!

Thank you for creating the follow-up bug!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: