Open Bug 2075913 Opened 1 month ago Updated 1 month ago

Use moz-button-group to setup the mini window selection mode preview buttons

Categories

(Firefox :: Tabbed Browser, task, P3)

task

Tracking

()

People

(Reporter: hsohaney, Assigned: hsohaney)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fide-engagement])

No description provided.
Whiteboard: [fide-engagement]

We should probably use moz-visual-picker type="listbox" here instead of moz-button-group. The "Move selection" / "Move full tab" tiles visually read as a visual picker, and moz-button-group only lays out buttons, so the custom tile styling (.mini-window-option) would still be needed.

A few things to keep in mind:

  • The existing "Choose what to move to a Mini Window" heading could become the picker's label, which also gives the group an accessible name.
  • Choosing an option is currently an immediate action (it closes the panel, or pops the tab). With the default type="radio" of the moz-visual-picker, arrow keys click the next item, so moving to "Move full tab" would pop a window. Either use type="listbox", where arrow keys only move focus, or switch to a "pick, then confirm" flow with a separate action button. UX and accessibility input would help here.
  • The data-default highlight on "Move selection" looks like a selected state. With a picker, this could become the initial value.
  • The picker has a single tab stop, so the Tab-wrapping between the panel and the overlay would need updating.

The Screenshots panel's "Save visible" / "Save full page" tiles have the same pattern, and bug 2083111 covers moving them to moz-visual-picker. Ideally both modes of the panel should end up using the same component.

See Also: → 2083111
You need to log in before you can comment on or make changes to this bug.