2076491 - Update New Tab train-hop runtime metrics generation to handle new extra_keys

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Irene Ni [:ini]]

As suggested in Bug 2076281, if Glean is able to register new extra_keys on an existing event at runtime, we can update our metrics generation script to include existing telemetry.

Comment 1

[Irene Ni [:ini]]

Attachment: Bug 2076491 - Update New Tab train-hop runtime metrics generation to handle new extra_keys on existing events. r=#home-newtab-reviewers

Comment 2

[BugBot [:suhaib / :marco]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit BugBot documentation.

Comment 3

[Irene Ni [:ini]]

Attachment: Bug 2076491 - Continue New Tab runtime metric registration past individual failures. r=#home-newtab-reviewers

Comment 4

[Irene Ni [:ini]]

Attachment: Bug 2076491 - Add a train-hop CI test for New Tab runtime events recording all extra keys. r=#home-newtab-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/738d032c675c
https://hg.mozilla.org/integration/autoland/rev/e3bef2af4440
Update New Tab train-hop runtime metrics generation to handle new extra_keys on existing events. r=mconley
https://github.com/mozilla-firefox/firefox/commit/2ca9f7cd685d
https://hg.mozilla.org/integration/autoland/rev/aa5eff349280
Continue New Tab runtime metric registration past individual failures. r=mconley
https://github.com/mozilla-firefox/firefox/commit/4cbf7b1359ba
https://hg.mozilla.org/integration/autoland/rev/d46556c102cb
Add a train-hop CI test for New Tab runtime events recording all extra keys. r=mconley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fdf5d518a28f
https://hg.mozilla.org/integration/autoland/rev/3fde972a91ce
Revert "Bug 2076491 - Add a train-hop CI test for New Tab runtime events recording all extra keys. r=mconley" for causing failures at test_NewTabGleanUtils.js.

Comment 7

[Atila Butkovits]

Backed out for causing failures at test_NewTabGleanUtils.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3fde972a91ce

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d46556c102cb00d2023fbcd83dec4c5916fd0290

Failure log: https://treeherder.mozilla.org/logviewer?job_id=599949476&repo=autoland&task=Nv1S9NDmSu271ZEFk_fntw.0&lineNumber=8750

Comment 8

[Irene Ni [:ini]]

Backout cause: Bug 1954203 (custom pings aren't re-registered after testResetFOG in compiled builds) silently dropped the event. The test now uses the built-in events ping.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f3db19dec2b1
https://hg.mozilla.org/integration/autoland/rev/ec36718ddfad
Update New Tab train-hop runtime metrics generation to handle new extra_keys on existing events. r=mconley
https://github.com/mozilla-firefox/firefox/commit/0746d58ae83d
https://hg.mozilla.org/integration/autoland/rev/5f64c9442b49
Continue New Tab runtime metric registration past individual failures. r=mconley
https://github.com/mozilla-firefox/firefox/commit/32578170bef0
https://hg.mozilla.org/integration/autoland/rev/58f109ff9221
Add a train-hop CI test for New Tab runtime events recording all extra keys. r=mconley

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ec36718ddfad
https://hg.mozilla.org/mozilla-central/rev/5f64c9442b49
https://hg.mozilla.org/mozilla-central/rev/58f109ff9221