2086669 - Remove the section_position guard in NewTabContentPing now that 159 is on Release

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mike Conley (:mconley) (:⚙️)]

sanitizeEventData() in lib/NewTabContentPing.sys.mjs deletes result.section_position on hosts in the 157 to 159 range. section_position was removed from the newtab_content impression and click extra_keys in 157 by bug 2067937 and restored in 159 by bug 2075383, so on a 157 or 158 host the key is unknown and glean-core would drop the whole event.

Firefox 159 reached Release on 2026-10-27 (Nightly is 161), so no supported train-hop target falls inside that range any more. Remove the version-range condition, the delete result.section_position it guards, and the @backward-compat comment.

Two notes:

• The shim is tagged @backward-compat { version 158 }, which was off by one: it could never have been removed at 158, because 158 is precisely one of the versions missing the key. A sweep filtering on 159 will not match this file.
• Bug 2076491 made this guard redundant independently of the release schedule. Runtime metrics now re-register an existing event that gained extra_keys, so a train-hopped XPI could already add section_position back on a 158 host. That no longer affects the outcome here, but it is the reason this is a plain deletion rather than a guard that needs to keep working.

The adjacent variant_id / source_section_id guard in the same function was already removed in bug 2084256, so nothing else in sanitizeEventData() depends on this one.

Shim introduced in bug 2075383.

Comment 1

[Hackbot [:hackbot]]

Attachment: Bug 2086669 - Remove the section_position backward-compat guard from NewTabContentPing.sanitizeEventData. r?ini!

Firefox 159 is on Release, so no supported train-hop host lacks the section_position extra_key on newtab_content impression/click events any more. Remove the 157–159 version-range check and the delete result.section_position it guarded.

That check was the only user of the eventName parameter and the AppConstants import, so both are removed too.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3aa25f5eb41
https://hg.mozilla.org/integration/autoland/rev/e16b1ac14237
Remove the section_position backward-compat guard from NewTabContentPing.sanitizeEventData. r=ini

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e16b1ac14237