Closed
Bug 2076794
Opened 1 month ago
Closed 29 days ago
AI Chatbot has duplicate switcher when revamp is toggled off while the panel is open
Categories
(Firefox :: Sidebar, defect, P1)
Firefox
Sidebar
Tracking
()
RESOLVED
FIXED
160 Branch
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: jsudiaman, Assigned: jsudiaman)
References
Details
(Whiteboard: [fidefe-sidebar])
Attachments
(1 file, 1 external file)
|
3.14 MB,
video/quicktime
|
Details |
Preconditions
Revamped sidebar is enabled.
In Customize sidebar:
- Vertical tabs is unchecked.
- Open tools from sidebar is unchecked.
- An AI provider has not been selected (i.e. no
browser.ml.chat.providerpref).
Steps to Reproduce
- Open the AI Chatbot panel.
- From
about:config, setsidebar.revamptofalse. - Switch back to the AI Chatbot panel.
Expected Result
The revamped switcher hides, and the legacy one is present.
Actual Result
Both switchers are present.
| Assignee | ||
Updated•1 month ago
|
Type: task → defect
Whiteboard: [fidefe-sidebar]
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
Summary: Sidebar: Handle switcher issues which may occur by manually setting visibility or revamp prefs → Handle switcher issues which may occur on AI Chatbot by manually setting visibility or revamp prefs
| Assignee | ||
Updated•1 month ago
|
Summary: Handle switcher issues which may occur on AI Chatbot by manually setting visibility or revamp prefs → Switcher issues may occur on AI Chatbot after setting visibility or revamp prefs
| Assignee | ||
Updated•1 month ago
|
Summary: Switcher issues may occur on AI Chatbot after setting visibility or revamp prefs → AI Chatbot can have duplicate switcher or outdated "inert" state
| Assignee | ||
Comment 1•1 month ago
|
||
| Assignee | ||
Updated•1 month ago
|
Summary: AI Chatbot can have duplicate switcher or outdated "inert" state → AI Chatbot has duplicate switcher when revamp is toggled off while the panel is open
Comment 2•1 month ago
|
||
The severity field is not set for this bug.
:kcochrane, could you have a look please?
For more information, please visit BugBot documentation.
Flags: needinfo?(kcochrane)
Updated•1 month ago
|
Flags: needinfo?(kcochrane) → needinfo?(nsharpley)
Updated•1 month ago
|
Severity: -- → S3
Flags: needinfo?(nsharpley)
Priority: -- → P1
| Assignee | ||
Comment 3•1 month ago
|
||
Bug 2077206 seems like the proper fix, taking a look.
| Assignee | ||
Comment 4•1 month ago
|
||
Pushed by jsudiaman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/be7d145c2350
https://hg.mozilla.org/integration/autoland/rev/e708d99a07aa
Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane
Pushed by abutkovits@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/5c124bc00a6d
https://hg.mozilla.org/integration/autoland/rev/31bff714a4ae
Revert "Bug 2076794, Bug 2006225, Bug 2077206 - Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane" for causing failures at browser_startup_images.js.
Comment 7•1 month ago
|
||
Backed out for causing failures at browser_startup_images.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/31bff714a4ae
Failure log: https://treeherder.mozilla.org/logviewer?job_id=599864824&repo=autoland&task=BuQYJJEmRzinLOvJKO28jg.0&lineNumber=1584
Flags: needinfo?(jsudiaman)
Pushed by jsudiaman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/60bd4fd510d9
https://hg.mozilla.org/integration/autoland/rev/6554764eda16
Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane
Pushed by sstanca@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8abd470dbab5
https://hg.mozilla.org/integration/autoland/rev/78b3449e5d89
Revert "Bug 2076794, Bug 2006225, Bug 2077206 - Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane" for causing wpt failures.
Comment 10•1 month ago
|
||
Reverted this because it was causing wpt failures.
- Revert link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | leakcheck large nsGlobalWindowInner | /clipboard-apis/permissions-policy/clipboard-read
Comment 11•29 days ago
|
||
Pushed by jsudiaman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/66567b3160e1
https://hg.mozilla.org/integration/autoland/rev/eedab65d12f1
Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane
Comment 12•29 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
status-firefox160:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
| Assignee | ||
Updated•29 days ago
|
Flags: needinfo?(jsudiaman)
Updated•17 days ago
|
QA Whiteboard: [qa-ver-needed-c161/b160]
Updated•17 days ago
|
QA Whiteboard: [qa-ver-needed-c161/b160] → [qa-triage-done-c160/b159]
You need to log in
before you can comment on or make changes to this bug.
Description
•