Closed Bug 2076794 Opened 1 month ago Closed 29 days ago

AI Chatbot has duplicate switcher when revamp is toggled off while the panel is open

Categories

(Firefox :: Sidebar, defect, P1)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: jsudiaman, Assigned: jsudiaman)

References

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(1 file, 1 external file)

Preconditions
Revamped sidebar is enabled.

In Customize sidebar:

  • Vertical tabs is unchecked.
  • Open tools from sidebar is unchecked.
  • An AI provider has not been selected (i.e. no browser.ml.chat.provider pref).

Steps to Reproduce

  1. Open the AI Chatbot panel.
  2. From about:config, set sidebar.revamp to false.
  3. Switch back to the AI Chatbot panel.

Expected Result
The revamped switcher hides, and the legacy one is present.

Actual Result
Both switchers are present.

Type: task → defect
Whiteboard: [fidefe-sidebar]
Summary: Sidebar: Handle switcher issues which may occur by manually setting visibility or revamp prefs → Handle switcher issues which may occur on AI Chatbot by manually setting visibility or revamp prefs
Summary: Handle switcher issues which may occur on AI Chatbot by manually setting visibility or revamp prefs → Switcher issues may occur on AI Chatbot after setting visibility or revamp prefs
Summary: Switcher issues may occur on AI Chatbot after setting visibility or revamp prefs → AI Chatbot can have duplicate switcher or outdated "inert" state
Summary: AI Chatbot can have duplicate switcher or outdated "inert" state → AI Chatbot has duplicate switcher when revamp is toggled off while the panel is open

The severity field is not set for this bug.
:kcochrane, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane) → needinfo?(nsharpley)
Severity: -- → S3
Flags: needinfo?(nsharpley)
Priority: -- → P1

Bug 2077206 seems like the proper fix, taking a look.

Assignee: nobody → jsudiaman
Status: NEW → ASSIGNED
Depends on: 2077206
No longer depends on: 2076296
Pushed by jsudiaman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/be7d145c2350 https://hg.mozilla.org/integration/autoland/rev/e708d99a07aa Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5c124bc00a6d https://hg.mozilla.org/integration/autoland/rev/31bff714a4ae Revert "Bug 2076794, Bug 2006225, Bug 2077206 - Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane" for causing failures at browser_startup_images.js.
Pushed by jsudiaman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/60bd4fd510d9 https://hg.mozilla.org/integration/autoland/rev/6554764eda16 Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8abd470dbab5 https://hg.mozilla.org/integration/autoland/rev/78b3449e5d89 Revert "Bug 2076794, Bug 2006225, Bug 2077206 - Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane" for causing wpt failures.

Reverted this because it was causing wpt failures.

Pushed by jsudiaman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/66567b3160e1 https://hg.mozilla.org/integration/autoland/rev/eedab65d12f1 Rewire AI Chatbot to use the shared switcher instance. r=desktop-theme-reviewers,sidebar-reviewers,yjamora,akulyk,kcochrane
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
Flags: needinfo?(jsudiaman)
QA Whiteboard: [qa-ver-needed-c161/b160]
QA Whiteboard: [qa-ver-needed-c161/b160] → [qa-triage-done-c160/b159]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: