2077206 - Extract <sidebar-panel-header> to a single element displayed over sidebar panels

Status: RESOLVED FIXED

(Firefox :: Sidebar, task)

Description

[Jonathan Sudiaman [:jsudiaman]]

Currently, all panels in the revamped sidebar include an instance of <sidebar-panel-header> in the DOM. This is inefficient, and can potentially introduce more bugs – such as Bug 2076296 – when adding or maintaining panels further down the line.

It is also apparent that loading this component directly inside of legacy panels can expose subtle XUL-based timing issues.

A more stable implementation would be one element, within the chrome that sits on top of the sidebar <browser>, that updates whenever the active panel changes.

This approach could take care of Bug 2076794 and Bug 2077473 as well.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 2077206 - Extract <sidebar-panel-header> to a single element displayed over sidebar panels r?#sidebar-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5da0f66d7e81
https://hg.mozilla.org/integration/autoland/rev/c2c9d7a7a37e
Extract <sidebar-panel-header> to a single element displayed over sidebar panels r=sidebar-reviewers,desktop-theme-reviewers,credential-management-reviewers,places-reviewers,kcochrane,sfoster,mtigley

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_startup_images.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/31bff714a4ae

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=BuQYJJEmRzinLOvJKO28jg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e708d99a07aafbe4c2cff648c9d59987dffa67f2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=599864824&repo=autoland&task=BuQYJJEmRzinLOvJKO28jg.0&lineNumber=1584

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/329c12136158
https://hg.mozilla.org/integration/autoland/rev/59f902b3b90d
Extract <sidebar-panel-header> to a single element displayed over sidebar panels r=sidebar-reviewers,desktop-theme-reviewers,credential-management-reviewers,places-reviewers,kcochrane,sfoster,mtigley

Comment 5

[Serban Stanca [:SerbanS]]

Reverted this because it was causing wpt failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | leakcheck large nsGlobalWindowInner | /clipboard-apis/permissions-policy/clipboard-read

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d1c9ac15bd7c
https://hg.mozilla.org/integration/autoland/rev/2e493f179fc9
Extract <sidebar-panel-header> to a single element displayed over sidebar panels r=sidebar-reviewers,desktop-theme-reviewers,credential-management-reviewers,places-reviewers,kcochrane,sfoster,mtigley

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2e493f179fc9