[wpt-sync] Sync PR 63216 - [line-clamp] Use the expected BFC offset in the LineClampAncestorChain
Categories
(Core :: Layout: Scrolling and Overflow, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 63216 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/63216
Details from upstream follow.
Andreu Botella <abotella@igalia.com> wrote:
[line-clamp] Use the expected BFC offset in the LineClampAncestorChain
Added in https://crrev.com/c/7566509, the
LineClampAncestorChainis
a data structure used to compute the expected automatic block size of
a line-clamp container if we were to clamp at a given point, which is
used in order to line-clamp based on a height. It does this by storing
data for the current block box and its ancestors up to the line-clamp
container in an immutable single linked list.One of the pieces of data the ancestor chain stores for each box is
its BFC offset. However, the ancestor chain for a box must be created
before any layout of its children, meaning that the BFC offset won't
be resolved at that point for any box other than the line-clamp
container itself.Previously this was handled by having the BFC offset field be a
std::optional, by creating a replacement chain once the BFC offset
is known, and by assuming that if a descendant node resolves its BFC
offset, all nodes in the ancestor chain that don't have a BFC offset
must end up with the BFC offset we just resolved. Unfortunately, this
approach ended up having holes in cases where a BFC offset is resolved
without causing a relayout.This patch instead refactors the ancestor chain so that it always
stores the expected BFC offset of each box, even if that expectation
is optimistic. It then also sets the
BlockLayoutAlgorithm::abort_when_bfc_block_offset_updated_flag, to
make sure we relayout to invalidate the expectation.This change regresses one WPT test,
line-clamp-auto-045.html, but
this seems to be due to a preexisting issue when
abort_when_bfc_block_offset_updated_is set, bug 568010387.Bug: 40336192, 561613778
Change-Id: I1e5068b86e88b3b957235f18b5f5c383483bf997Reviewed-on: https://chromium-review.googlesource.com/8501743
WPT-Export-Revision: 2b2c288350b939b337a0f26b81625531697d2152
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 1•1 month ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=99872
| Assignee | ||
Comment 2•1 month ago
|
||
CI Results
Ran 11 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI
Total 305 tests
Status Summary
Firefox
OK : 1
PASS : 9[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 11[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 199[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 200[Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt] 202[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt]
FAIL : 1[GitHub] 103[Gecko-linux2404-64-debug] 104[Gecko-linux2404-64-opt] 105[Gecko-windows11-64-25h2-debug] 106[Gecko-windows11-64-25h2-opt] 107[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
ERROR: 1
Chrome
PASS : 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /css/css-overflow/line-clamp/block-ellipsis-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-005.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-006.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-012.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-015.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-016.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-017.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-018.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-019.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-020.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-021.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-025.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-027.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-028.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-029.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-030.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-032.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-033.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-035.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-036.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-039.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-040.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-041.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-bidi-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-bidi-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-bidi-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-quirk-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-quirk-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/block-ellipsis-repaint-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/continue-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-001.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/discard/discard-multicol-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-021.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-023.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-024.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-025.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-036.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-009.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-010.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-025.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-032.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-034.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-039.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-041.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/css-overflow/line-clamp/line-clamp-auto-043.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-044.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-045.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-046.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-047.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-auto-063.html [wpt.fyi]:
ERROR[Gecko-linux2404-64-debug,Gecko-windows11-64-25h2-debug],FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-opt,GitHub] (Chrome:PASS) - /css/css-overflow/line-clamp/line-clamp-auto-with-ruby-005.tentative.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-002.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-005.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-overflow/line-clamp/line-clamp-balance-006.html [wpt.fyi]:
FAIL[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview],PASS[Gecko-linux2404-64-debug,Gecko-linux2404-64-opt,Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt] - /css/css-overflow/line-clamp/line-clamp-balance-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-011.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-balance-012.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-016.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-017.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-019.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-abspos-023.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-fixed-pos-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-005.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-006.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-009.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-010.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-011.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-012.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-013.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-floats-014.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-003.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-004.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-005.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-006.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-007.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-008.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/line-clamp-with-text-overflow-string-009.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-024.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-036.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-037.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-043.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-048.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-049.html [wpt.fyi]:
FAIL[Gecko-windows11-64-25h2-debug,Gecko-windows11-64-25h2-opt],PASS[Gecko-android-em-14-x86_64-debug-geckoview,Gecko-android-em-14-x86_64-lite-opt-geckoview,Gecko-android-em-14-x86_64-opt-geckoview,Gecko-linux2404-64-debug,Gecko-linux2404-64-opt] - /css/css-overflow/line-clamp/webkit-line-clamp-051.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-052.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-053.html [wpt.fyi]:
FAIL - /css/css-overflow/line-clamp/webkit-line-clamp-abspos-001.html [wpt.fyi]:
FAIL
https://hg.mozilla.org/mozilla-central/rev/56b2eaa13d11
https://hg.mozilla.org/mozilla-central/rev/dcd20bc9b6b5
Description
•