Closed Bug 2077970 Opened 1 month ago Closed 14 days ago

New wpt failures in /css/css-overflow/line-clamp/line-clamp-auto-063.html

Categories

(Core :: Layout: Scrolling and Overflow, defect, P3)

defect
Points:
3

Tracking

()

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: wpt-sync, Assigned: kyoety)

References

(Blocks 1 open bug)

Details

(Whiteboard: [wpt], css-line-clamp)

Attachments

(1 external file)

Syncing wpt PR 63216 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

  • /css/css-overflow/line-clamp/line-clamp-auto-063.html [wpt.fyi]: ERROR [Gecko-linux2404-64-debug, Gecko-windows11-64-25h2-debug], FAIL [Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-opt, GitHub] (Chrome: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 2077691 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Severity: -- → S3
Priority: -- → P3
Depends on: 2081347
Depends on: 2079858

To fix this, we will need to consider max-height in line-clamp: auto containers.

Assignee: nobody → kye
Points: --- → 3
Whiteboard: [wpt] → [wpt], css-line-clamp
Attachment #9670220 - Attachment description: Bug 2077970 - Account for descendant max-height in containers with line-clamp: auto. r=dshin,alaskanemily → Bug 2077970 - Account for descendant max-height in containers with line-clamp: auto. r=dshin,alaskanemily Moved handling of constrained block and into `LineClampIterator()`, so `FindLineClampAutoTarget()` is solely focused on inline line checks.
Attachment #9670220 - Attachment description: Bug 2077970 - Account for descendant max-height in containers with line-clamp: auto. r=dshin,alaskanemily Moved handling of constrained block and into `LineClampIterator()`, so `FindLineClampAutoTarget()` is solely focused on inline line checks. → Bug 2077970 - Account for descendant max-height in containers with line-clamp: auto. r=dshin,alaskanemily
Pushed by kye@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f1eaab02175f https://hg.mozilla.org/integration/autoland/rev/2c8441607227 Account for descendant max-height in containers with line-clamp: auto. r=AlaskanEmily
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/042f92bac4d6 https://hg.mozilla.org/integration/autoland/rev/c8052fbf7482 Revert "Bug 2077970 - Account for descendant max-height in containers with line-clamp: auto. r=AlaskanEmily" for causing wr failures on line-clamp-auto-045.html.

Revert for causing wr failures on line-clamp-auto-045.html.

Flags: needinfo?(kye)
Pushed by kye@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/cefd6338feda https://hg.mozilla.org/integration/autoland/rev/ac63de064872 Account for descendant max-height in containers with line-clamp: auto. r=AlaskanEmily
Status: NEW → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
Flags: needinfo?(kye)
Duplicate of this bug: 2092610
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: