2078239 - View > Folders does nothing in the calendar and tasks tabs

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Nico D.]

Steps to reproduce:

1. Open the Calendar tab.
2. Open View > Folders in the menu bar.
3. Check "Tags".
4. Go back to the Mail tab and open View > Folders.

Actual results:
In the Calendar tab the menu items look usable and get a check mark when clicked.
But nothing changes: the Mail tab does not show the Tags folders, and "Tags" is not checked there.

Expected results:
View > Folders is only enabled in a mail tab, and greyed out in other tabs.
This is how View > Calendar already works the other way round: it is greyed out in the Mail tab and enabled in the Calendar tab.

Notes:

• Since bug 1806922 (Thunderbird 110), folderViewMenuOnCommand returns early when currentAbout3Pane is null, so the choice is dropped. The check mark only comes from the menu item itself.
• Since bug 1838770 (Thunderbird 116), _onFoldersViewShow reads currentAbout3Pane.gFolder before its null check.
• Found while writing tests for bug 2076478.

Comment 1

[Mirko Kerezovic]

Attachment: Bug 2078239 - Disable folder views menu outside mail tabs. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0b883f7b4ff2
Disable folder views menu outside mail tabs. r=tobyp