2079706 - Remove the sync-auth custom tab exemption from the onboarding gate once continuous onboarding is the default

Status: RESOLVED INVALID

(Firefox for Android :: Onboarding, task, P3)

Description

[twhite]

Bug 2040608 made HomeActivity show onboarding before the user can reach the rest of the app. To keep sign-in working while onboarding is still on screen, isAllowedDuringOnboardingIntent in AllowedDuringOnboardingIntent.kt lets two intents through without showing onboarding: sandboxed custom tabs and this build's sync-auth custom tab, matched by isIntentComponentSyncAuth against AuthCustomTabActivity.

The sync-auth exemption carries a note that continuous onboarding will make it irrelevant and that it should be removed when continuous onboarding becomes the default in bug 2046788. Under continuous onboarding the sign-in step no longer needs to open a custom tab on top of an unfinished onboarding flow, so the component check has nothing left to exempt.

Once bug 2046788 has shipped as the default:

• Remove isIntentComponentSyncAuth and the AUTH_CUSTOM_TAB_ACTIVITY_CLASS_NAME constant from AllowedDuringOnboardingIntent.kt.
• Drop the packageName parameter from isAllowedDuringOnboardingIntent if the sandboxed custom tab check is the only remaining case, and update the call site in HomeActivity.
• Remove the sync-auth cases from AllowedDuringOnboardingIntentTest.

Comment 1

[twhite]

The exemption is still needed, so I'm closing this as INVALID. Bug 2092621 covers updating the note on isIntentComponentSyncAuth to explain why it stays, and that it can only be removed once no onboarding card launches FxA authentication. If the pairing card's email sign-in moves out of the onboarding flow later, the removal can be filed again then.