2092621 - Update the note on the sync-auth custom tab exemption in the onboarding gate to explain why it is still needed

Status: ASSIGNED

(Firefox for Android :: Onboarding, task)

Description

[twhite]

Bug 2079706 proposed removing the sync-auth custom tab exemption from the onboarding gate once continuous onboarding became the default (bug 2046788). It was closed as invalid because the exemption is still needed: the sync-pairing onboarding card is shown before onboarding completes, and its email button (onSyncPairingEmailClick in OnboardingFragment) calls accountsAuthFeature.beginAuthentication, which opens AuthCustomTabActivity. That activity extends ExternalAppBrowserActivity and goes through the onboarding gate in HomeActivity, so without the exemption the auth custom tab would show onboarding instead of the FxA sign-in page.

The note on isIntentComponentSyncAuth in AllowedDuringOnboardingIntent.kt still says the check should be removed once bug 2046788 lands, which is no longer accurate. Update it to explain why the exemption stays, and that it can only be removed once no onboarding card launches FxA authentication.

Comment 1

[BMO Github Automation]

Attachment: [mozilla-firefox/firefox] Bug 2092621 - Update the docs on the isIntentComponentSyncAuth sync-auth custom tab exemption to explain why it is still needed. (#448)

(via GitHub webhook, authenticated as shared-secret)