Closed
Bug 2080275
Opened 1 month ago
Closed 15 days ago
Convert tabnote-menu.js to a module
Categories
(Firefox :: Tabbed Browser, task)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
161 Branch
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(3 external files)
browser/components/tabbrowser/content/tabnote-menu.js is loaded into the browser window with Services.scriptloader.loadSubScript, so the tabbrowser TypeScript project can't check it. Convert it to a module that browser-main.js imports with { global: "current" }, the way bug 2066073 did for tabgroup.js and tabsplitview.js. The tsconfig's content/*.mjs include will then pick it up.
| Assignee | ||
Comment 1•1 month ago
|
||
| Assignee | ||
Comment 2•1 month ago
|
||
| Assignee | ||
Comment 3•1 month ago
|
||
Updated•16 days ago
|
Assignee: nobody → dao+bmo
Attachment #9657180 -
Attachment description: WIP: Bug 2080275 - Declare SidebarController for type-checked modules that run in the browser window. r?Standard8 → Bug 2080275 - Declare SidebarController for type-checked modules that run in the browser window. r?Standard8
Status: NEW → ASSIGNED
Updated•16 days ago
|
Attachment #9657181 -
Attachment description: WIP: Bug 2080275 - Type the tab note menu's fragment and telemetry source. r?#tabbrowser-reviewers → Bug 2080275 - Type the tab note menu's fragment and telemetry source. r?#tabbrowser-reviewers
Updated•16 days ago
|
Attachment #9657182 -
Attachment description: WIP: Bug 2080275 - Rename the tab note menu script to .mjs (no functional change). r?#tabbrowser-reviewers → Bug 2080275 - Rename the tab note menu script to .mjs (no functional change). r?#tabbrowser-reviewers
Updated•16 days ago
|
Attachment #9657180 -
Attachment description: Bug 2080275 - Declare SidebarController for type-checked modules that run in the browser window. r?Standard8 → Bug 2080275 - Declare the _positionStart property of SidebarController for TypeScript. r?Standard8
Pushed by dgottwald@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/2dfb85f32afe
https://hg.mozilla.org/integration/autoland/rev/be7cbd5b8cae
Declare the _positionStart property of SidebarController for TypeScript. r=Standard8
https://github.com/mozilla-firefox/firefox/commit/825da1d019c4
https://hg.mozilla.org/integration/autoland/rev/8749d5d8f652
Type the tab note menu's fragment and telemetry source. r=tabbrowser-reviewers,kcochrane
https://github.com/mozilla-firefox/firefox/commit/dffaa78a3407
https://hg.mozilla.org/integration/autoland/rev/8c6974edee63
Rename the tab note menu script to .mjs (no functional change). r=tabbrowser-reviewers,kcochrane
https://hg.mozilla.org/mozilla-central/rev/be7cbd5b8cae
https://hg.mozilla.org/mozilla-central/rev/8749d5d8f652
https://hg.mozilla.org/mozilla-central/rev/8c6974edee63
Status: ASSIGNED → RESOLVED
Closed: 15 days ago
status-firefox161:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
Updated•10 days ago
|
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in
before you can comment on or make changes to this bug.
Description
•