Load `tabnote-menu`, `split-view-footer`, `tabgroup-menu` and `drag-and-drop` .mjs as actual modules rather than sub scripts
Categories
(Firefox :: Tabbed Browser, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(2 external files)
Bug 2080275, bug 2080288, bug 2080287 and bug 2080286 rename tabnote-menu, split-view-footer, tabgroup-menu and drag-and-drop to .mjs while browser-main.js still loads them with loadSubScript. Each wraps its code in a block, which has to go before the file can export anything, and removing it reindents the whole file. This bug removes the four blocks and loads the files with ChromeUtils.importESModule and { global: "current" } in one commit, so .git-blame-ignore-revs and .hg-annotate-ignore-revs need a single entry.
| Assignee | ||
Comment 1•1 month ago
|
||
Dropping each block, exporting the class and loading the file with importESModule can't be split: once a block is gone, the loadSubScript line hands the file's own top-level names back to it as globals. git diff -w shows the actual change, plus lines prettier re-joined.
split-view-footer.mjs reads the window's BrowserUtils, which utilityOverlay.js defines from the same module, because this is undefined at a module's top level. tabs.mjs imports TabDragAndDrop, which loads drag-and-drop.mjs, so browser-main.js no longer loads it.
Updated•13 days ago
|
| Assignee | ||
Comment 3•12 days ago
|
||
Comment 4•11 days ago
|
||
| bugherder | ||
Comment 6•7 days ago
|
||
| bugherder | ||
Description
•