Open Bug 2080406 Opened 1 month ago Updated 16 days ago

Pinned tab dragged in the expanded vertical tab strip isn't re-centered under the cursor

Categories

(Firefox :: Tabbed Browser, defect, P3)

defect

Tracking

()

People

(Reporter: dao, Unassigned)

References

Details

(Whiteboard: [fidefe-tabbrowser])

In _animateExpandedPinnedTabMove in drag-and-drop.js, the check meant to center the dragged tab under the cursor compares the bare screen, which is window.screen, against pixel offsets:

if (
  screen < draggedTab.screenY + translateY ||
  screen > draggedTab.screenY + tabHeight + translateY
) {
  translateY = screen - draggedTab.screenY - tabHeight / 2;
}

Both comparisons are always false, so the branch never runs. It presumably meant the event's screenY. Found while converting the file to a module in bug 2080286.

The severity field is not set for this bug.
:nsharpley, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(nsharpley)
Severity: -- → S4
Flags: needinfo?(nsharpley)
Priority: -- → P3
Whiteboard: [fidefe-tabbrowser]
You need to log in before you can comment on or make changes to this bug.