Closed
Bug 2080286
Opened 1 month ago
Closed 13 days ago
Convert drag-and-drop.js to a module
Categories
(Firefox :: Tabbed Browser, task)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
162 Branch
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
browser/components/tabbrowser/content/drag-and-drop.js is loaded into the browser window with Services.scriptloader.loadSubScript, so the tabbrowser TypeScript project can't check it. Convert it to a module loaded with { global: "current" }, the way bug 2066073 did for tabgroup.js and tabsplitview.js. The tsconfig's content/*.mjs include will then pick it up.
| Assignee | ||
Comment 1•1 month ago
|
||
The .mjs extension turns on no-shadow with builtinGlobals, so locals named after window globals (screen, top, screenX, screenY, SidebarController) are renamed, and the local Tabbrowser import is dropped in favor of the window's Tabbrowser, which is the same module.
The file joins the tsconfig exclude list: tsc reports 93 errors in it once content/*.mjs matches.
Updated•14 days ago
|
Assignee: nobody → dao+bmo
Attachment #9657190 -
Attachment description: WIP: Bug 2080286 - Rename the tab drag and drop script to .mjs (no functional change). r?#tabbrowser-reviewers → Bug 2080286 - Rename the tab drag and drop script to .mjs (no functional change). r?#tabbrowser-reviewers
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/88640ae9d4a6
https://hg.mozilla.org/integration/autoland/rev/46aa294bd2b6
Rename the tab drag and drop script to .mjs (no functional change). r=tabbrowser-reviewers,kcochrane
Comment 3•13 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
status-firefox162:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•