208132 - add new build flag to enable rich and plaintext editing (no composer app)

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

This bug is for discussion/patches related to a new build flag for rich text
editing (and plaintext editing) but not build composer.

Currently we have these configure options/build flags:
  --enable-plaintext-editor-only   MOZILLA_PLAINTEXT_EDITOR_ONLY
  --disable-composer               MOZ_COMPOSER

There are several steps that will need to be made.
First, EditorOverride.css needs to not be in editor/ui/composer/content/
I propose moving it to editor/composer/src/res/

Next, we need to settle on build flags and defines.

Once we have build flags, I think I can pare down the composer commands a little
to reduce the size of the composer dll.  I'm not sure yet how big of a win this
will be.  I suspect it will be fairly small.

cc'ing lots of people who I think have asked about this recently; apologies to
those I incorrectly cc and those I miss this round.

Comment 1

[Kathleen :Brade]

Attachment: step 1

Comment 2

[Brian Ryner (not reading)]

Comment on attachment 125088 [details] [diff] [review]
step 1

r=bryner, but please have the file copied in the repository to preserve
history.

As for the configure flags, the traditional way we've done it is to have
--disable-foo options to remove things from the build.	In this case, that
would mean:

--disable-composer (disable composer UI, and any composer-specific c++)

--disable-html-editing (replacing --enable-plaintext-editor-only) to not build
editor/libeditor/html and editor/composer

Personally I don't think it makes sense to have a define to build
editor/libeditor/html and _not_ build editor/composer (the midas stuff).

Comment 3

[Kathleen :Brade]

Attachment: step 2: fix MOZ_COMPOSER to be specific to moz_composer

obsoleting step 1 patch since it has landed

plan: step 3 will be to rename --enable-plaintext-editor-only to
--disable-html-editing

For the moment, the plan is to provide these build options for apps:
  --disable-html-editing (plaintext only, no midas, no composer)
  --disable-composer (plaintext and html editing for midas, no composer)
  default (plaintext, midas, composer)

If there is a problem with the above options, please mention here ASAP or file
a new bug.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 125224 [details] [diff] [review]
step 2: fix MOZ_COMPOSER to be specific to moz_composer

r=me

Comment 5

[Kathleen :Brade]

Comment on attachment 125224 [details] [diff] [review]
step 2: fix MOZ_COMPOSER to be specific to moz_composer

obsoleting patch; checked in today (revision 1.5)

Comment 6

[roxx]

Yes, Mozilla won't let you use rich text on Hotmail. It also won't open
attachments in a new window, a new Mozilla browser opens, making you log in
again to infinity.

Comment 7

[Kathleen :Brade]

roxx--I think your comment (comment 6) is in the wrong bug or perhaps you
intended to file a new bug?

I'm not sure what remaining work for this bug is left so I am going to resolve
the bug.

dbaron, bryner, others: let me know if I've forgotten a step or something.