2082190 - Auto-save moves the focus to where it was during last manual save leading to inadvertent focus change while typing

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Helge H.]

STR:
Enter message subject
Enter message body, save manually, enter some more text so auto-save will be triggered
Place caret subject field. Wait for auto-save. Notice caret is moved to body.
If you type into the subject while auto-save happens, the text goes into the body, not the the subject.

STR 2:
Enter message subject, save manually.
Enter message body, so auto-save will be triggered. Wait for auto-save.
Notice caret is moved to subject.
If you type into the body while auto-save happens, the text goes into the subject.

It's quite surprising and annoying that the caret position suddenly changes and the text goes where you don't want it to go.

Apparently it's a one line fix.

Comment 1

[Mirko Kerezovic]

Attachment: Bug 2082190 - Avoid restoring stale compose focus during auto-save r=darktrojan

Reset the saved active element after unlocking the compose window. Auto-save does not lock the window, but its completion still unlocks it and could restore an outdated focus from a previous manual save.

Add a browser regression test for both subject-to-body and body-to-subject focus changes.

Fix based on Betterbird NNN37-fix-wrong-focus-auto-save.patch: https://github.com/Betterbird/thunderbird-patches/blob/main/153/bugs/NNN37-fix-wrong-focus-auto-save.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6d2d65431fd3
Avoid restoring stale compose focus during auto-save r=tobyp