Credit card Rust migration reports false divergences for cards whose number mask has no digits or whose expiry is stored as 0
Categories
(Toolkit :: Form Autofill, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: dimi, Assigned: dimi)
References
Details
Attachments
(1 external file)
The Nightly credit card migration dry run (bug 2081661) reports records as
diverged after copying them from the JSON store into the Rust store. The cards
themselves were copied correctly; the verification step's comparison is wrong.
| Assignee | ||
Comment 1•1 month ago
|
||
The migration verify compared cc-number by the last four characters of each
store's mask. The JSON store masks a number that fails isValidNumber entirely
in *, while the Rust store keeps the real last four, so those cards were
reported as diverged although the number reached Rust intact. Matching last
four digits also let a number that differed elsewhere pass.
Compare the number each store decrypts for the record instead. A source that
cannot read its own number is not compared; a copy whose number cannot be read
back is reported as having dropped it.
The Rust expiry columns are non-optional integers, so a JSON record holding
cc-exp-month or cc-exp-year as 0 read back without the field and was reported
as "added". Both sides mean no expiry, so that pair now compares equal.
Comment 3•1 month ago
|
||
| bugherder | ||
Updated•23 days ago
|
Description
•