Closed Bug 2082829 Opened 1 month ago Closed 1 month ago

Credit card Rust migration reports false divergences for cards whose number mask has no digits or whose expiry is stored as 0

Categories

(Toolkit :: Form Autofill, task, P2)

task

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

Attachments

(1 external file)

The Nightly credit card migration dry run (bug 2081661) reports records as
diverged after copying them from the JSON store into the Rust store. The cards
themselves were copied correctly; the verification step's comparison is wrong.

The migration verify compared cc-number by the last four characters of each
store's mask. The JSON store masks a number that fails isValidNumber entirely
in *, while the Rust store keeps the real last four, so those cards were
reported as diverged although the number reached Rust intact. Matching last
four digits also let a number that differed elsewhere pass.

Compare the number each store decrypts for the record instead. A source that
cannot read its own number is not compared; a copy whose number cannot be read
back is reported as having dropped it.

The Rust expiry columns are non-optional integers, so a JSON record holding
cc-exp-month or cc-exp-year as 0 read back without the field and was reported
as "added". Both sides mean no expiry, so that pair now compares equal.

Pushed by dlee@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/98b9ef545502 https://hg.mozilla.org/integration/autoland/rev/153b110ad63b Credit card Rust migration reports false divergences for cards whose number mask has no digits or whose expiry is stored as 0. r=joschmidt,credential-management-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
See Also: → 2085806
QA Whiteboard: [qa-triage-done-c161/b160]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: