Credit card Rust migration dry run shows issues to fix
Categories
(Toolkit :: Form Autofill, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: dimi, Assigned: dimi)
References
Details
(Whiteboard: [fxcm-backlog])
Attachments
(3 external files)
Found in the Nightly dry run (bug 2081661): on macOS and Linux, the copy into the Rust store waits for the OS key store and starts at its unlock. That unlock happens in the middle of the user's own action (a fill, a submission, a save, or editing a card in settings), so that action's write lands during the copy, or after the switch in the old JSON store. In the real migration, the write is lost.
| Assignee | ||
Updated•24 days ago
|
Updated•24 days ago
|
| Assignee | ||
Comment 1•23 days ago
|
||
The JSON store keeps serving while it is copied, and the unlock that starts a
deferred credit card copy is usually a fill, whose use count update lands
after the export. The copy then switched to Rust without it. The migrator now
fails such a run like any other, so it is retried on a later launch.
Writes are not held back during the copy, as the password migration does by
running before its store is handed out: the credit card copy usually starts
mid-session, on the OS key store's first unlock, so every write path would
have to wait on it. Detecting the write leaves callers unchanged.
| Assignee | ||
Comment 2•23 days ago
|
||
The unlock lands in the middle of the action that caused it: a submission's
duplicate check, a save's encryption, or opening a card for editing. That
action's own write then fell inside the copy, or after the switch into a store
that no longer serves.
A copy waiting for the key store now starts at the first of these safe points
reached with the key store unlocked, each of which has left nothing pending:
- the end of a fill (FormAutofillParent.autofillFields);
- the end of a form submission, once any doorhanger it showed is done with,
its save included (FormAutofillParent.onFormSubmit; promptToSave now awaits
the save); - the closing of the card editor in settings (EditCreditCardDialog).
Depends on D337526
| Assignee | ||
Comment 3•23 days ago
|
||
The deferred credit card migration was its only listener, and now waits for a
safe point instead.
Depends on D337527
Comment 5•22 days ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7c5f759c29bb
https://hg.mozilla.org/mozilla-central/rev/50c1d3349b17
https://hg.mozilla.org/mozilla-central/rev/4edabeda72e6
Updated•11 days ago
|
Description
•