20832 - [Skins] XPInstall is not skinnable

Status: VERIFIED FIXED

(Core Graveyard :: Skinability, defect, P3)

Description

[David Hyatt]

Tracking bug for problems with this package.

Comment 1

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

Comment 2

[dbragg]

In the process of fixing 21559, I needed to add "skinnability".  Feexed.

Comment 3

[David Hyatt]

These are placeholder bugs to track skinnability.  It is not currently possible
that this could be fixed.  (You may have improved things, but you probably
haven't fixed them all together.)

Reopening.

Comment 4

[dbragg]

Oops.  Sorry, I misunderstood and got caught in a frenzy, yes frenzy of bug
fixing.

Comment 5

[msanz]

Adding [beta], since we will be localizig it, and making a dependency for 12394.

Comment 6

[tao]

These are pre-requisites of localizable chrome. Marking them [BETA]. Please fix
them by M14 so that we can be ready for localization. To make the chrome
localizable, the font name, font size, and UI geometry setting needs to be
externalized and move to chrome/[package]/locale/*.css.

Adding lyecies, amasri, and tao into CC list.


Thanks

Comment 7

[dbragg]

Tao, could you specify where the xpinstall dialogs are in error?  I don't have
any style values in the .xul files anymore, nor do I have size or font values.
I do have a few spring values but I don't think those are a problem.
Thanks.

Comment 8

[dbragg]

We don't know what this bug means, pushing out milestone and thinking of
closing. Would someone like to explain exactly what is NOT skinnable in
XPInstall so we can fix it?

Comment 9

[tao]

Hi, Don:

To address this bug, we need to make chrome skinnable first. You'll need to work
with Hyatt on this.

Then, we need to look at the new skin files to identify any localizable
resources such as fontname, fontsize, and UI geometry settings, and move
them into locale/. This could be done by moving the skin files containing
such resousrces into locale/ or simply extract those resources into a
separate skin file and place it under locale.

In xpinstall.css, there is a font setting at,

http://lxr.mozilla.org/mozilla/source/xpinstall/res/skin/xpinstall.css#53.

We might not need to touch xpinstall at all if the font setting could be
fixed in the global skin files.

In this case, we're better off making the chrome skinnable first and address the
localizability after that. IQA is going through a "Japanese" M12 and will log
bugs if any UI setting need to be localized.

Thanks a lot for your attention.

Comment 10

[leger]

Due to Beta indication in Summary, putting beta1 into keyword field.

Comment 11

[Cathleen]

skin support is not in, so this bug can't be done till after beta.  
removing beta1, setting target milestone to M16 for now.

Comment 12

[Peter Trudelle]

Adding 'skins' keyword to appropriate bugs en masse, sorry about any 
mistakes...

Comment 13

[Peter Trudelle]

Mass-adding beta2 keyword to all skins bugs.

Comment 14

[Doug Turner (:dougt)]

up to cathleen for redelegation...

Comment 15

[Cathleen]

reassign to dveditz  :-)

talked to dveditz before, he doesn't mind taking on this task from dbragg.

Comment 16

[Cathleen]

*** Bug 37746 has been marked as a duplicate of this bug. ***

Comment 17

[leger]

Putting on [nsbeta2-] radar. Not critical to beta2.

Comment 18

[Daniel Veditz [:dveditz]]

*** Bug 41709 has been marked as a duplicate of this bug. ***

Comment 19

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 20

[leger]

blake...we believe this is fixed per you :-)  Is it?  Or is this a dup of a bug 
you did fix?

Comment 21

[Blake Ross]

Yeah, with my last two checkins tonight this should be fixed...it was really 
just a collaboration of two other bugs I have, anyways.  Thanks for the pointer 
Jan.

By the way, I'm not sure if those localizability issues brought up earlier have 
been fixed, but if not, please file a separate bug for them.  Thanks.

(sending to skinability so I can verify)

Comment 22

[Blake Ross]

vrfy fixed - today's builds