Closed Bug 20832 Opened 26 years ago Closed 26 years ago

[Skins] XPInstall is not skinnable

Categories

(Core Graveyard :: Skinability, defect, P3)

Product:
Core Graveyard
Component:
Skinability
Platform:
x86
Other
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: hyatt, Assigned: bugzilla)

References

Details

(Whiteboard: [nsbeta2-])

Tracking bug for problems with this package.
Assignee: cathleen → dbragg
Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall Engine
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
In the process of fixing 21559, I needed to add "skinnability". Feexed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
These are placeholder bugs to track skinnability. It is not currently possible that this could be fixed. (You may have improved things, but you probably haven't fixed them all together.) Reopening.
Oops. Sorry, I misunderstood and got caught in a frenzy, yes frenzy of bug fixing.
Blocks: 22176
Adding [beta], since we will be localizig it, and making a dependency for 12394.
Blocks: 12394
Summary: [Skins] XPInstall is not skinnable → [BETA][Skins] XPInstall is not skinnable
Target Milestone: M13
These are pre-requisites of localizable chrome. Marking them [BETA]. Please fix them by M14 so that we can be ready for localization. To make the chrome localizable, the font name, font size, and UI geometry setting needs to be externalized and move to chrome/[package]/locale/*.css. Adding lyecies, amasri, and tao into CC list. Thanks
Tao, could you specify where the xpinstall dialogs are in error? I don't have any style values in the .xul files anymore, nor do I have size or font values. I do have a few spring values but I don't think those are a problem. Thanks.
Target Milestone: M13 → M14
We don't know what this bug means, pushing out milestone and thinking of closing. Would someone like to explain exactly what is NOT skinnable in XPInstall so we can fix it?
Hi, Don: To address this bug, we need to make chrome skinnable first. You'll need to work with Hyatt on this. Then, we need to look at the new skin files to identify any localizable resources such as fontname, fontsize, and UI geometry settings, and move them into locale/. This could be done by moving the skin files containing such resousrces into locale/ or simply extract those resources into a separate skin file and place it under locale. In xpinstall.css, there is a font setting at, http://lxr.mozilla.org/mozilla/source/xpinstall/res/skin/xpinstall.css#53. We might not need to touch xpinstall at all if the font setting could be fixed in the global skin files. In this case, we're better off making the chrome skinnable first and address the localizability after that. IQA is going through a "Japanese" M12 and will log bugs if any UI setting need to be localized. Thanks a lot for your attention.
Due to Beta indication in Summary, putting beta1 into keyword field.
Keywords: beta1
skin support is not in, so this bug can't be done till after beta. removing beta1, setting target milestone to M16 for now.
Keywords: beta1
Summary: [BETA][Skins] XPInstall is not skinnable → [Skins] XPInstall is not skinnable
Target Milestone: M14 → M16
Adding 'skins' keyword to appropriate bugs en masse, sorry about any mistakes...
Keywords: skins
Blocks: 29160
Mass-adding beta2 keyword to all skins bugs.
Keywords: beta2
Keywords: nsbeta2
up to cathleen for redelegation...
Assignee: dbragg → cathleen
Status: REOPENED → NEW
Keywords: beta2
reassign to dveditz :-) talked to dveditz before, he doesn't mind taking on this task from dbragg.
Assignee: cathleen → dveditz
*** Bug 37746 has been marked as a duplicate of this bug. ***
Putting on [nsbeta2-] radar. Not critical to beta2.
Whiteboard: [nsbeta2-]
*** Bug 41709 has been marked as a duplicate of this bug. ***
M16 has been out for a while now, these bugs target milestones need to be updated.
No longer blocks: 22176
blake...we believe this is fixed per you :-) Is it? Or is this a dup of a bug you did fix?
Assignee: dveditz → BlakeR1234
Yeah, with my last two checkins tonight this should be fixed...it was really just a collaboration of two other bugs I have, anyways. Thanks for the pointer Jan. By the way, I'm not sure if those localizability issues brought up earlier have been fixed, but if not, please file a separate bug for them. Thanks. (sending to skinability so I can verify)
Status: NEW → RESOLVED
Closed: 26 years ago → 26 years ago
Component: Installer: XPInstall Engine → Skinability
QA Contact: jimmylee → BlakeR1234
Resolution: --- → FIXED
vrfy fixed - today's builds
Status: RESOLVED → VERIFIED
Keywords: skins
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.