2083639 - "Search <engine> for <term>" doesn't work on web pages / start mail page

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mark Banner (:standard8)]

STR

1. Start up Thunderbird
2. On the "Mail Start Page", double-click to select some text, right Click and select "Search <engine> for <selection>".

Alternate:

1. Open the add-ons manager
2. Search for an add-on
3. On the page that appears, select some text, right Click and select "Search <engine> for <selection>".

Alternate:

1. Install Thunderbird Conversations
2. Select a message
3. Highlight text in the message, right Click and select "Search <engine> for <selection>".

Expected Results

A search is opened in the default browser

Actual Result

Nothing happens. On the Error Console there is a message:

10:09:10.825 Uncaught ReferenceError: openWebSearch is not defined
    oncommand chrome://messenger/content/messenger.xhtml:1
 messenger.xhtml:1:1

mozregression gives this range: https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=87f4f09099b98ffbe0aeb6e5706338bdc05c5afe&tochange=6feef4b46387240f031aeea774f908bc1ec4fd47

From code inspection, that suggests bug 1866725 as the regressor.

Comment 1

[Airat Makhmutov]

Also reproduced on Thunderbird 158.0.1 (Flathub), Linux. Not limited to the start page and the add-ons search results: the same error comes from every content tab (e.g. the privacy notice tab opened on first run, addons.thunderbird.net search results) and from about:addons. The message body context menu item works.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 2083639 - Fix "Search <engine> for <term>" doesn't work on web pages / start mail page. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b1d851689dcb
Fix "Search <engine> for <term>" doesn't work on web pages / start mail page. r=aleca