2084061 - Investigate treating NSIS compiler warnings as errors with /WX

Status: NEW

(Firefox :: Installer, enhancement, P3)

Description

[Mauro Ferreiro [:mferreiro] (he/him)]

Bug 2070532 exposed an NSIS compiler warning about an unreferenced
GetPostUpdateTarget function during Firefox packaging. In comment 3,
Aurora suggested considering the /WX flag to treat warnings as errors
and catch similar issues earlier.

Investigate whether we can enable /WX for Firefox's NSIS compilation.

Scope:

• Identify the relevant makensis invocations in packaging and tests.
• Verify support in the NSIS version used by our build infrastructure.
• Assess existing warnings across the relevant build configurations
  and identify any blockers to enabling /WX.
• Recommend where to enable it and file follow-up bugs as needed.

Expected outcome:
A documented recommendation and, if feasible, a patch enabling /WX,
with validation that compiler warnings cause the affected build step
to fail.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Bug 2084061: Fix existing string-formatting warnings in `moz.configure`. r?#firefox-build-system-reviewers

Comment 2

[Stephen A Pohl [:spohl]]

Attachment: Bug 2084061: Treat Firefox NSIS compiler warnings as errors. r?#firefox-build-system-reviewers,#browser-installer-reviewers!,yjuglaret!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c6f8a397348c
https://hg.mozilla.org/integration/autoland/rev/3a7822e4bfcc
Fix existing string-formatting warnings in `moz.configure`. r=firefox-build-system-reviewers,sergesanspaille

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4fc7662e357c
https://hg.mozilla.org/integration/autoland/rev/8f7c31e312e2
Revert "Bug 2084061: Fix existing string-formatting warnings in `moz.configure`. r=firefox-build-system-reviewers,sergesanspaille" for causing mozbuild failures

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing mozbuild failures

Backout link

Push with failures

Failure log

Comment 6

[Stephen A Pohl [:spohl]]

(In reply to Norisz Fay [:noriszfay] from comment #5)

Backed out for causing mozbuild failures

Backout link

Push with failures

Failure log

Oh, I didn't mean to land this patch before we had https://phabricator.services.mozilla.com/D336507 reviewed. I'll fix things up and hold it.