Open Bug 2085981 Opened 23 days ago Updated 23 days ago

Localized Windows installers fail to compile with NSIS warnings as errors

Categories

(Firefox :: Installer, defect)

defect

Tracking

()

ASSIGNED

People

(Reporter: spohl, Assigned: spohl)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Compiling the Arabic Windows installer with NSIS warnings as errors (-WX) fails with:

warning 6040: LangString "OPTIONAL_EXTENSIONS_CHECKBOX_DESC" is not set in language table of language baseLocale
Error: warning treated as error

MOZ_OPTIONAL_EXTENSIONS limits the optional-extensions page to en-US and zh-CN, but the related initialization in .onInit appears to run for all locales and reference strings absent from their language tables.

The proposed patch makes the optional-extension variables and initialization conditional on MOZ_OPTIONAL_EXTENSIONS, matching the page. This should unblock localized installer compilation for bug 2084061.

Severity: -- → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: