Closed Bug 2085056 Opened 29 days ago Closed 28 days ago

Update the New Tab build docs now that the build generates the bundles in the objdir

Categories

(Firefox :: New Tab Page, task)

task

Tracking

()

RESOLVED FIXED
161 Branch
Tracking Status
firefox161 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Since bug 2025793 and bug 2062117, ./mach build and ./mach build faster generate css/ and data/content/*.bundle.js in the objdir. ./mach newtab bundle and ./mach newtab watch still write them into the source tree (npm run bundle sets no outputPath), where they are untracked. addon-jar.mn resolves ./css/activity-stream.css and the bundles against the source tree before the objdir, so a leftover copy wins and New Tab runs it however stale, while every build looks clean.

The docs still describe the old layout: docs/index.md recommends ./mach newtab bundle && ./mach build, and AGENTS.md says the bundle is copied to browser/components/newtab/.

They should say where each command writes, that source-tree copies shadow the build output, and how to clear them: delete them, then touch browser/extensions/newtab/addon-jar.mn && ./mach build faster.

Blocks: 2071608
No longer blocks: 2071613
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1a6eb82e7588 https://hg.mozilla.org/integration/autoland/rev/966e1a251173 Document where the New Tab bundle commands write and how to remove bundles left in the source tree. r=ai4dev-reviewers,fchasen,padenot DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 28 days ago
Resolution: --- → FIXED
Target Milestone: --- → 161 Branch
QA Whiteboard: [qa-triage-done-c162/b161]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: