Closed Bug 2071613 Opened 2 months ago Closed 14 days ago

Add desktop-theme skills for writing, reviewing and debugging front-end styling

Categories

(Developer Infrastructure :: AI for Development, task)

task

Tracking

(firefox162 fixed)

RESOLVED FIXED
162 Branch
Tracking Status
firefox162 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 2 open bugs)

Details

Attachments

(3 external files, 3 obsolete files)

Proposed skills with their descriptions:

  • desktop-theme-colors - CSS issues, changes and reviews involving color - high contrast, forced colors, prefers-contrast, dark mode, system colors; a border, shadow, focus ring or icon that vanishes; states like hover/selected/focus that don't look distinct; a color right in chrome but wrong in an about: page or vice versa.
  • desktop-theme-layout - Front-end CSS and markup issues and changes that move, size or clip a box - overflow, scrollbars, centering, RTL, fractional scaling, font size, density, zoom, popovers, anchors; trusting a geometry reading from one setup.
  • desktop-theme-tokens - Design tokens and CSS variables - picking one for a hard-coded value, *.tokens.json edits, Nova/Figma overrides, buildtokens, value-neutral diffs; one undefined or ineffective on a surface; finding the revision that changed a token's value.
  • desktop-theme-screenshots - Before/after screenshots for a bug or review; pixel-diffing a pair to prove a change visually neutral; shooting a hover or open-menu state; sampling a reporter's image; showing a hit area, focus target or stacking order.
  • desktop-theme-probing - Use when measuring anything off a running Firefox (geometry, a computed style, media-query or pseudo-class state, a pref, window state, focus, a timing) through the devtools MCP, firefox-probe.py, a Marionette chrome-context probe or a scratch browser-chrome test; when writing or editing such a probe, even a small edit; when it needs --no-headless, xvfb-run, a headless compositor or the live desktop, or a headless run cannot see a value; when a chrome CSS, .xhtml or script edit does not show after a reload, or a launch dies on Missing chrome or resource URL; when a probe launch's state differs from a user's (remote-control stripes, an empty profile, about:blank); and before trusting a number a probe printed. (This skill is marked as name-only, so its description doesn't add to permanent context.)

firefox-desktop-frontend points at the family for design tokens and for verifying a theming change. The family doesn't route through it, because names alone miss requests that leave the subject implicit. desktop-theme-colors and accessibility-frontend-review don't name each other; colors points at the in-tree docs both draw on.

See bug 2071608 comment 0 for more details and examples for the skills in action.

desktop-theme-probing is set name-only: the four subject skills name it in prose, which is the only thing that routes to a name-only skill.

Summary: Add the theme-debug skills for diagnosing front-end theming problems → Add theme-debug skills for diagnosing front-end theming problems
Attachment #9641510 - Attachment description: WIP: Bug 2071613 - Add the theme-debug skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD → WIP: Bug 2071613 - Add theme-debug skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #9641510 - Attachment description: WIP: Bug 2071613 - Add theme-debug skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD → Bug 2071613 - Add theme-debug skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD
Attachment #9641510 - Attachment description: Bug 2071613 - Add theme-debug skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD → WIP: Bug 2071613 - Add theme-debug skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD
Attachment #9642564 - Attachment description: WIP: Bug 2071613 - Name the current privileged-context tools in the devtools MCP docs. r?#ai4dev-reviewers → WIP: Bug 2071613 - Fix the stale tool names in the devtools MCP docs. r?#ai4dev-reviewers
Summary: Add theme-debug skills for diagnosing front-end theming problems → Add desktop-theme skills for diagnosing front-end theming problems
Attachment #9641510 - Attachment description: WIP: Bug 2071613 - Add theme-debug skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD → WIP: Bug 2071613 - Add desktop-theme skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD
Summary: Add desktop-theme skills for diagnosing front-end theming problems → Add desktop-theme skills for writing, reviewing and debugging front-end styling
Attachment #9641510 - Attachment description: WIP: Bug 2071613 - Add desktop-theme skills for diagnosing front-end theme, color and layout problems. r?#ai4dev-reviewers DONTBUILD → WIP: Bug 2071613 - Add desktop-theme skills for writing, reviewing and debugging front-end styling. r?#ai4dev-reviewers DONTBUILD
See Also: → 2082041
Keywords: leave-open
Attachment #9642564 - Attachment description: WIP: Bug 2071613 - Fix the stale tool names in the devtools MCP docs. r?#ai4dev-reviewers → Bug 2071613 - Fix the stale tool names in the devtools MCP docs. r?#ai4dev-reviewers
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/341057831388 https://hg.mozilla.org/integration/autoland/rev/db102a31e21c Fix the stale tool names in the devtools MCP docs. r=ai4dev-reviewers,padenot DONTBUILD
Attachment #9660877 - Attachment description: Bug 2071613 - Correct the forced-colors and env(hairline) claims in the HCM media query docs and CSS guidelines. r?#desktop-theme-reviewers,mkennedy DONTBUILD → Bug 2071613 - Correct the forced-colors and env(hairline) claims in the HCM media query docs and CSS guidelines. r?#desktop-theme-reviewers DONTBUILD
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6925f60434b2 https://hg.mozilla.org/integration/autoland/rev/f3320ca1b32f Correct the forced-colors and env(hairline) claims in the HCM media query docs and CSS guidelines. r=desktop-theme-reviewers,akulyk DONTBUILD
Attachment #9641510 - Attachment description: WIP: Bug 2071613 - Add desktop-theme skills for writing, reviewing and debugging front-end styling. r?#ai4dev-reviewers DONTBUILD → Bug 2071613 - Add desktop-theme skills for writing, reviewing and debugging front-end styling. r?padenot!,tgiles DONTBUILD
Depends on: 2085056
No longer depends on: 2085056
Attachment #9667114 - Attachment is obsolete: true

Comment on attachment 9666958 [details]
Bug 2071613 - Correct the env(hairline) fallback and the forced-colors border-color fallbacks in the CSS guidelines. r?#desktop-theme-reviewers

Revision D336287 was moved to bug 2085331. Setting attachment 9666958 [details] to obsolete.

Attachment #9666958 - Attachment is obsolete: true

Comment on attachment 9667115 [details]
Bug 2071613 - Document how ./mach buildtokens --import-figma brings Figma values into the Nova token overrides. r?#desktop-theme-reviewers

Revision D336345 was moved to bug 2085331. Setting attachment 9667115 [details] to obsolete.

Attachment #9667115 - Attachment is obsolete: true
Keywords: leave-open
Pushed by dgottwald@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f3a0092b418f https://hg.mozilla.org/integration/autoland/rev/de9ec0f39ccc Add desktop-theme skills for writing, reviewing and debugging front-end styling. r=ai4dev-reviewers,padenot,tgiles DONTBUILD
See Also: → 2090033
Blocks: 2090033
See Also: 2090033 →
See Also: → 2090042
Blocks: 2082041, 2090042
See Also: 2082041, 2090042 →
Status: ASSIGNED → RESOLVED
Closed: 14 days ago
Resolution: --- → FIXED
Target Milestone: --- → 162 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: