Add desktop-theme skills for writing, reviewing and debugging front-end styling
Categories
(Developer Infrastructure :: AI for Development, task)
Tracking
(firefox162 fixed)
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 2 open bugs)
Details
Attachments
(3 external files, 3 obsolete files)
Proposed skills with their descriptions:
desktop-theme-colors- CSS issues, changes and reviews involving color - high contrast, forced colors, prefers-contrast, dark mode, system colors; a border, shadow, focus ring or icon that vanishes; states like hover/selected/focus that don't look distinct; a color right in chrome but wrong in an about: page or vice versa.desktop-theme-layout- Front-end CSS and markup issues and changes that move, size or clip a box - overflow, scrollbars, centering, RTL, fractional scaling, font size, density, zoom, popovers, anchors; trusting a geometry reading from one setup.desktop-theme-tokens- Design tokens and CSS variables - picking one for a hard-coded value, *.tokens.json edits, Nova/Figma overrides, buildtokens, value-neutral diffs; one undefined or ineffective on a surface; finding the revision that changed a token's value.desktop-theme-screenshots- Before/after screenshots for a bug or review; pixel-diffing a pair to prove a change visually neutral; shooting a hover or open-menu state; sampling a reporter's image; showing a hit area, focus target or stacking order.desktop-theme-probing- Use when measuring anything off a running Firefox (geometry, a computed style, media-query or pseudo-class state, a pref, window state, focus, a timing) through the devtools MCP,firefox-probe.py, a Marionette chrome-context probe or a scratch browser-chrome test; when writing or editing such a probe, even a small edit; when it needs--no-headless,xvfb-run, a headless compositor or the live desktop, or a headless run cannot see a value; when a chrome CSS,.xhtmlor script edit does not show after a reload, or a launch dies onMissing chrome or resource URL; when a probe launch's state differs from a user's (remote-control stripes, an empty profile, about:blank); and before trusting a number a probe printed. (This skill is marked as name-only, so its description doesn't add to permanent context.)
firefox-desktop-frontend points at the family for design tokens and for verifying a theming change. The family doesn't route through it, because names alone miss requests that leave the subject implicit. desktop-theme-colors and accessibility-frontend-review don't name each other; colors points at the in-tree docs both draw on.
See bug 2071608 comment 0 for more details and examples for the skills in action.
| Assignee | ||
Comment 1•2 months ago
•
|
||
desktop-theme-probing is set name-only: the four subject skills name it in prose, which is the only thing that routes to a name-only skill.
| Assignee | ||
Updated•2 months ago
|
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
Updated•2 months ago
|
| Assignee | ||
Comment 2•2 months ago
|
||
Updated•2 months ago
|
Updated•2 months ago
|
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
| Assignee | ||
Comment 3•1 month ago
|
||
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
Updated•1 month ago
|
Comment 6•1 month ago
|
||
| bugherder | ||
Updated•29 days ago
|
| Assignee | ||
Comment 7•28 days ago
|
||
| Assignee | ||
Comment 8•28 days ago
|
||
| Assignee | ||
Comment 9•28 days ago
|
||
Updated•28 days ago
|
Comment 10•28 days ago
|
||
Comment on attachment 9666958 [details]
Bug 2071613 - Correct the env(hairline) fallback and the forced-colors border-color fallbacks in the CSS guidelines. r?#desktop-theme-reviewers
Revision D336287 was moved to bug 2085331. Setting attachment 9666958 [details] to obsolete.
Comment 11•28 days ago
|
||
Comment on attachment 9667115 [details]
Bug 2071613 - Document how ./mach buildtokens --import-figma brings Figma values into the Nova token overrides. r?#desktop-theme-reviewers
Revision D336345 was moved to bug 2085331. Setting attachment 9667115 [details] to obsolete.
| Assignee | ||
Updated•14 days ago
|
Comment 12•14 days ago
|
||
| Assignee | ||
Updated•14 days ago
|
| Assignee | ||
Updated•14 days ago
|
Comment 13•14 days ago
|
||
| bugherder | ||
Description
•