Open Bug 2085254 Opened 28 days ago Updated 14 days ago

Update the Nova menu item text colors in Figma to use the ghost text colors in dark mode

Categories

(Toolkit :: Themes, task)

task

Tracking

()

People

(Reporter: dao, Unassigned, NeedInfo)

References

Details

Attachments

(1 external file)

In Nova dark, Figma gives disabled, hovered, pressed and selected menu items the button.text.color.* values instead of the ghost ones. Those dark values never painted, so bug 2084656 overrides button.text.color.menu.active, .disabled, .hover and .selected in button.tokens.json to use the ghost text colors in both color schemes.

The Figma import skips tokens with a code-side Nova override, so these four will drift from Figma until it is updated. Once Figma has the ghost values in dark too, fetch and import them and remove the overrides along with their TODO comments.

Not ready to land: Figma doesn't have these values yet, so this edits the committed export by hand; it needs a real Figma import once bug 2085254 updates Figma.

Hey Jules, would you be able to help with this?

Flags: needinfo?(jules)

I think Mark covered it

Flags: needinfo?(jules) → needinfo?(mstriemer)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: